From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36632C432BE for ; Tue, 17 Aug 2021 16:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1182F60BD3 for ; Tue, 17 Aug 2021 16:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230413AbhHQQbd (ORCPT ); Tue, 17 Aug 2021 12:31:33 -0400 Received: from mxout04.lancloud.ru ([45.84.86.114]:41324 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230431AbhHQQbV (ORCPT ); Tue, 17 Aug 2021 12:31:21 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru 760B020CDD44 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH net-next v2 8/8] ravb: Add tx_drop_cntrs to struct ravb_hw_info To: Biju Das , Sergei Shtylyov , "David S. Miller" , "Jakub Kicinski" CC: Geert Uytterhoeven , Sergey Shtylyov , Adam Ford , Andrew Lunn , Yuusuke Ashizuka , Yoshihiro Shimoda , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Biju Das , "Prabhakar Mahadev Lad" References: <20210802102654.5996-1-biju.das.jz@bp.renesas.com> <20210802102654.5996-9-biju.das.jz@bp.renesas.com> <24d63e2c-8f3b-9f75-a917-e7dc79085c84@gmail.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <9b09e2ba-4e92-6e1e-e26b-c2a3152f7fe4@omp.ru> Date: Tue, 17 Aug 2021 19:30:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 8/17/21 6:47 PM, Biju Das wrote: [...] >>> The register for retrieving TX drop counters is present only on R-Car >>> Gen3 and RZ/G2L; it is not present on R-Car Gen2. >>> >>> Add the tx_drop_cntrs hw feature bit to struct ravb_hw_info, to enable >>> this feature specifically for R-Car Gen3 now and later extend it to >> RZ/G2L. >>> >>> Signed-off-by: Biju Das >>> Reviewed-by: Lad Prabhakar >>> --- >>> v2: >>> * Incorporated Andrew and Sergei's review comments for making it >> smaller patch >>> and provided detailed description. >>> --- >>> drivers/net/ethernet/renesas/ravb.h | 1 + >>> drivers/net/ethernet/renesas/ravb_main.c | 4 +++- >>> 2 files changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ethernet/renesas/ravb.h >>> b/drivers/net/ethernet/renesas/ravb.h >>> index 0d640dbe1eed..35fbb9f60ba8 100644 >>> --- a/drivers/net/ethernet/renesas/ravb.h >>> +++ b/drivers/net/ethernet/renesas/ravb.h >>> @@ -1001,6 +1001,7 @@ struct ravb_hw_info { >>> >>> /* hardware features */ >>> unsigned internal_delay:1; /* RAVB has internal delays */ >>> + unsigned tx_drop_cntrs:1; /* RAVB has TX error counters */ >> >> I suggest 'tx_counters' -- this name comes from the sh_eth driver for >> the same regs (but negated meaning). And please don't call the hardware >> RAVB. :-) > > Agreed. Will change it to 'tx_counters' on next version and comment it as > /* AVB-DMAC has TX counters */ The counters belong to E-MAC, not AVB-DMAC. > Cheers, > Biju MBR, Sergey