Netdev Archive on
help / color / mirror / Atom feed
From: Pavel Tikhomirov <>
To: Jakub Kicinski <>
Cc:, "David S. Miller" <>,
	Arnd Bergmann <>, Eric Dumazet <>,
	Paolo Abeni <>, Florian Westphal <>,,,,,,,
	Andrei Vagin <>
Subject: Re: [PATCH v2] sock: allow reading and changing sk_userlocks with setsockopt
Date: Mon, 2 Aug 2021 11:26:09 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 30.07.2021 19:46, Jakub Kicinski wrote:
> On Fri, 30 Jul 2021 19:07:08 +0300 Pavel Tikhomirov wrote:
>> SOCK_SNDBUF_LOCK and SOCK_RCVBUF_LOCK flags disable automatic socket
>> buffers adjustment done by kernel (see tcp_fixup_rcvbuf() and
>> tcp_sndbuf_expand()). If we've just created a new socket this adjustment
>> is enabled on it, but if one changes the socket buffer size by
>> setsockopt(SO_{SND,RCV}BUF*) it becomes disabled.
>> CRIU needs to call setsockopt(SO_{SND,RCV}BUF*) on each socket on
>> restore as it first needs to increase buffer sizes for packet queues
>> restore and second it needs to restore back original buffer sizes. So
>> after CRIU restore all sockets become non-auto-adjustable, which can
>> decrease network performance of restored applications significantly.
>> CRIU need to be able to restore sockets with enabled/disabled adjustment
>> to the same state it was before dump, so let's add special setsockopt
>> for it.
>> Signed-off-by: Pavel Tikhomirov <>
> The patchwork bot is struggling to ingest this, please double check it
> applies cleanly to net-next.

I checked that it applies cleanly to net-next:

[snorch@fedora linux]$ git am 
~/Downloads/patches/ptikhomirov/setsockopt-sk_userlocks/\[PATCH\ v2\]\ 
sock\:\ allow\ reading\ and\ changing\ sk_userlocks\ with\ setsockopt.eml

[snorch@fedora linux]$ git log --oneline
c339520aadd5 (HEAD -> net-next) sock: allow reading and changing 
sk_userlocks with setsockopt

d39e8b92c341 (net-next/master) Merge

Probably it was some temporary problem and now it's OK?


Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.

  reply	other threads:[~2021-08-02  8:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 16:07 Pavel Tikhomirov
2021-07-30 16:46 ` Jakub Kicinski
2021-08-02  8:26   ` Pavel Tikhomirov [this message]
2021-08-02 16:11     ` Jakub Kicinski
2021-08-03 11:04       ` Pavel Tikhomirov
2021-08-03 12:42         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] sock: allow reading and changing sk_userlocks with setsockopt' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).