Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: b53: Fix calculating number of switch ports
Date: Wed, 1 Sep 2021 10:16:54 -0700 [thread overview]
Message-ID: <9f9b4bb7-2fae-3ce5-b6ce-3372e8de1196@gmail.com> (raw)
In-Reply-To: <20210901092141.6451-1-zajec5@gmail.com>
On 9/1/2021 2:21 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It isn't true that CPU port is always the last one. Switches BCM5301x
> have 9 ports (port 6 being inactive) and they use port 5 as CPU by
> default (depending on design some other may be CPU ports too).
>
> A more reliable way of determining number of ports is to check for the
> last set bit in the "enabled_ports" bitfield.
>
> This fixes b53 internal state, it will allow providing accurate info to
> the DSA and is required to fix BCM5301x support.
>
> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
For a bug fix, this looks appropriate to me, and for net-next, we need
to remove the dev->num_ports and b53_for_each_port() entirely as there
is no need to duplicate what DSA already maintains for us. Thanks!
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-09-01 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 9:21 Rafał Miłecki
2021-09-01 9:21 ` [PATCH net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Rafał Miłecki
2021-09-01 17:21 ` Florian Fainelli
2021-09-01 23:36 ` Jakub Kicinski
2021-09-02 1:38 ` Florian Fainelli
2021-09-01 17:16 ` Florian Fainelli [this message]
2021-09-02 8:30 ` [PATCH V2 net 1/2] net: dsa: b53: Fix calculating number of switch ports Rafał Miłecki
2021-09-02 8:30 ` [PATCH V2 net 2/2] net: dsa: b53: Set correct number of ports in the DSA struct Rafał Miłecki
2021-09-02 12:40 ` [PATCH V2 net 1/2] net: dsa: b53: Fix calculating number of switch ports patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f9b4bb7-2fae-3ce5-b6ce-3372e8de1196@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafal@milecki.pl \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=zajec5@gmail.com \
--subject='Re: [PATCH net 1/2] net: dsa: b53: Fix calculating number of switch ports' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).