From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23037C433E6 for ; Wed, 2 Sep 2020 06:16:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C64C206C0 for ; Wed, 2 Sep 2020 06:16:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dektech.com.au header.i=@dektech.com.au header.b="D5noxq2y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbgIBGQt (ORCPT ); Wed, 2 Sep 2020 02:16:49 -0400 Received: from mail-eopbgr00136.outbound.protection.outlook.com ([40.107.0.136]:25875 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726140AbgIBGQt (ORCPT ); Wed, 2 Sep 2020 02:16:49 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eY6rFyfnKsJwxYayYhZlj0HbMIc+QxySQIZNz6yObRaz0Mqma7Cv2WkS7x92g062TTIC3zicYxCFs/9Sj1JtGQ/cLY9+nBQN005ASaLNnELw938Ain2qIFpU6jnU+2AuKXP60H2o119wvTQmSNTa64kZDFFphArQZlg7GzGhB2EYAuumiE09lkRyc3MwNZs+/C0X+dVCzf0DZ2Vh9+f1QcKthektcE9xRB5xrUV1Cau2iAOth9qsfrZP93fBbtbkHVjxy/za3lTfJYGflRyQC3TeVNXoQ9gfFrPJwuf2dCmjKVWxohlKsJTO1hV+fuOlMf7Yq2uoMLEqXkajkrHt9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4r/aycaofDryifPVOT/RrTZizaA3z5XPwgFNTWmAJU=; b=GchIYHIXZxZvyV0vFA7r2CgGD0GtDfz5dN6syYTt2b3tEat7kRHRv/IwG0Mtk3zb6zJu4TFJF/8+9c5jMga0h10z7oVE2u4TY3kIuFYkMoWrCalSi2iVCXYOpIBmebDUpFHr79jD3Op2f6btIcg91gKhi6p+lQHb3WW3Ji86IahA6badsp8prtnsDfrXC/C1KAL2/NL8iDogr6AcApx0+C6Xiz9lyIz6hds7WOyv+GGg5nu/5WglrVQIyakrOT2l4P0biS7r/RxjkSrt1/3aZckaqKBgWuzXQ9mKjKEArKkc2qBgy5pd8CE8T+L1kcbT9w5YLbnlZ+sVg6Vj6IW6bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dektech.com.au; dmarc=pass action=none header.from=dektech.com.au; dkim=pass header.d=dektech.com.au; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dektech.com.au; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4r/aycaofDryifPVOT/RrTZizaA3z5XPwgFNTWmAJU=; b=D5noxq2ySN+w7YNWuPQCRBO+bTzptArpvraptA5pqCNDPtUgk3TUQ7KoCoWYspsE3BXxVdLsS6OEe7jVr29gwUqy8FexbwMtaeHJ4ElJ/aVS61qZcTcWbP+m8lpDNlet11OHsKdBBMRby+a7Bx0M0akXOJtVtLbUfCuzO2pohz8= Received: from AM8PR05MB7332.eurprd05.prod.outlook.com (2603:10a6:20b:1db::9) by AM4PR0501MB2292.eurprd05.prod.outlook.com (2603:10a6:200:53::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.22; Wed, 2 Sep 2020 06:16:44 +0000 Received: from AM8PR05MB7332.eurprd05.prod.outlook.com ([fe80::64de:d33d:e82:b902]) by AM8PR05MB7332.eurprd05.prod.outlook.com ([fe80::64de:d33d:e82:b902%7]) with mapi id 15.20.3348.015; Wed, 2 Sep 2020 06:16:44 +0000 From: Tuong Tong Lien To: David Miller CC: "jmaloy@redhat.com" , "maloy@donjonn.com" , "ying.xue@windriver.com" , "netdev@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" Subject: RE: [net-next v2 1/4] tipc: optimize key switching time and logic Thread-Topic: [net-next v2 1/4] tipc: optimize key switching time and logic Thread-Index: AQHWgFljycnWru2qvU2zDy6vbXHU46lUWLMAgAB+fLA= Date: Wed, 2 Sep 2020 06:16:44 +0000 Message-ID: References: <20200831083817.3611-1-tuong.t.lien@dektech.com.au> <20200831083817.3611-2-tuong.t.lien@dektech.com.au> <20200901.151028.670408362469941141.davem@davemloft.net> In-Reply-To: <20200901.151028.670408362469941141.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=dektech.com.au; x-originating-ip: [123.20.195.8] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56505f6f-8889-4a79-482b-08d84f07c407 x-ms-traffictypediagnostic: AM4PR0501MB2292: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3HTgVaJdGEXamvTeg8+y9ESlNB39EmJGKBhcA8Ga9+vbPly7afjfOyQ6pyNScPbOO2OgduNFMUvL4vPvjSBxW/VMO6VNmswG0fYSllIbqHorvw04DzbV8zGiCIJGoW16363qiZqZdIciStVTMBmpcylnpNzjxsd7Z3H6x8jzrwehThIOeGM+Ac0iSUxnNX+CMJB8wnabtzEeNg2mk0Tl3uxMDevR8sWBseIAzZe0QFozxwL2FEDgY41c4cwGAu0Waqu2qJiYLOr+xwD5A0C7GqTWLqym32JH6jdYMBqkbYovn1BLUhTi4VB+O5SdQaHsiKYqEUQY7MxZBTWIesNG/A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR05MB7332.eurprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(396003)(39850400004)(376002)(136003)(55236004)(2906002)(186003)(7696005)(4326008)(316002)(8676002)(9686003)(33656002)(54906003)(6916009)(8936002)(53546011)(83380400001)(66556008)(76116006)(5660300002)(55016002)(6506007)(66946007)(52536014)(26005)(71200400001)(478600001)(66476007)(66446008)(64756008)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: +ZoUWG4bpXoyTfMlmggULYyKghBnpzHMM5hkwLmJGegLo1s8Jc2P9PQ5D1aLZ+bRh7bh6zFDklzpWZewZ4iXObtI7iuSuWYR+kwrGBJVC1icl3EWZWH0WonV6L7AIf2o6OToe4s3AHfoHQmV4s6X8V08q87ACOz5u77pHz1C1dF9qc/HDWtMXrYv5uZOa/NylhY1YFM1xo/DiVDx7Jdpglduy8CDUesV2dqQX0OsqDFphIjbYuM7ExH9U4y834zxPWvd62Y7MgPktO4yDhjwGhD9KJMTnBW4wnnpuI93+SurtEys0cYRcs9UIjY8s9mKtPPNGl7UniOJqIDo8fDT/t4Y2WB55d+yabupF8lkOVS+RkwU9Hxbc4taO0iGONYxOzouk6gNzI2oRqu4Fbp/GPTmWPAyLcD8pL8tuoFeWugK9CyY+ZAp5zODjppqgbjbdIMBlFNFLRr5Xo/SvvH6WF76spuLqfIeA9V+Yg+oWM6JTYch95CpLkN6bzo3qcwRUzLS9pSUj6kwpcKLkufVdHDx+GRf5POY9D5gokq98qAF8OsPzJ4/9FRUK76zTPcNTy1RovNx5pwHtFGDtU3asLEUOXnWOxJOhK7ziI/2EAmaZjq2xGa56G/cAdls2J1f0Tdv/Wfd6OXVHoPGl6GPQQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: dektech.com.au X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR05MB7332.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56505f6f-8889-4a79-482b-08d84f07c407 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 06:16:44.4201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 1957ea50-0dd8-4360-8db0-c9530df996b2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +loD/KBD5Qzg4KmLCziapS71DM9hy3IgYPQb8H5bV6nixnYcKH1H7UiQLbHLRMAY2cMeH2oyFcjtsaVeBIyTigqRDAgHPFzt1VNnuBTR/g0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2292 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: David Miller > Sent: Wednesday, September 2, 2020 5:10 AM > To: Tuong Tong Lien > Cc: jmaloy@redhat.com; maloy@donjonn.com; ying.xue@windriver.com; netdev@= vger.kernel.org; tipc- > discussion@lists.sourceforge.net > Subject: Re: [net-next v2 1/4] tipc: optimize key switching time and logi= c >=20 > From: Tuong Lien > Date: Mon, 31 Aug 2020 15:38:14 +0700 >=20 > > We reduce the lasting time for a pending TX key to be active as well as > > for a passive RX key to be freed which generally helps speed up the key > > switching. It is not expected to be too fast but should not be too slow > > either. Also the key handling logic is simplified that a pending RX key > > will be removed automatically if it is found not working after a number > > of times; the probing for a pending TX key is now carried on a specific > > message user ('LINK_PROTOCOL' or 'LINK_CONFIG') which is more efficient > > than using a timer on broadcast messages, the timer is reserved for use > > later as needed. > > > > The kernel logs or 'pr***()' are now made as clear as possible to user. > > Some prints are added, removed or changed to the debug-level. The > > 'TIPC_CRYPTO_DEBUG' definition is removed, and the 'pr_debug()' is used > > instead which will be much helpful in runtime. > > > > Besides we also optimize the code in some other places as a preparation > > for later commits. > > > > This commit does not change the en/decryption functionalities. > > > > Acked-by: Jon Maloy > > Signed-off-by: Tuong Lien >=20 > Random log messages in response to user config requests are > inappropriate especially with netlink. >=20 > Report such informational responses to errors using the > genl_info->extack instead, as is standard practice across > the entire kernel. >=20 > Please remove all kernel log messages that get emitted due to > netlink operations and use extack notifications instead. Yes, the netlink extack message is fine but the fact is that we currently d= o not obtain such message from the user space tool (i.e. iproute2/tipc). So= , if really needed, we will have to update the tool as well... For now, I w= ill remove all the message logs as it is fine enough with the return code. >=20 > I also disagree with the commit message stating: >=20 > This commit does not change the en/decryption functionalities. >=20 > You are changing timer lengths and other aspects of crypto behavior, > so the patch is in fact changing things. Ok, will remove this statement (this patch was merged from two different on= es, so indeed made some changes). Thanks for the comments! BR/Tuong