Netdev Archive on
help / color / mirror / Atom feed
From: Brian Norris <>
To: "Gustavo A. R. Silva" <>
Cc: Amitkumar Karwar <>,
	Ganapathi Bhat <>,
	Sharvari Harisangam <>,
	Xinming Hu <>,
	Kalle Valo <>,
	"David S. Miller" <>,
	Jakub Kicinski <>,
	linux-wireless <>,
	"<>" <>,
	Linux Kernel <>,
Subject: Re: [PATCH][next] mwifiex: usb: Replace one-element array with flexible-array member
Date: Mon, 9 Aug 2021 14:24:07 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20210809211134.GA22488@embeddedor>

On Mon, Aug 9, 2021 at 2:08 PM Gustavo A. R. Silva
<> wrote:
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use “flexible array members”[1] for these cases. The older
> style of one-element or zero-length arrays should no longer be used[2].
> This helps with the ongoing efforts to globally enable -Warray-bounds
> and get us closer to being able to tighten the FORTIFY_SOURCE routines
> on memcpy().
> This issue was found with the help of Coccinelle and audited and fixed,
> manually.
> [1]
> [2]
> Link:
> Link:
> Signed-off-by: Gustavo A. R. Silva <>

An important part of your patch rationale should include determining
that the 1-length wasn't actually important anywhere. I double checked
for you, and nobody seemed to be relying on 'sizeof struct fw_data' at
all, so this should be OK:

Reviewed-by: Brian Norris <>

  reply	other threads:[~2021-08-09 21:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 21:11 [PATCH][next] mwifiex: usb: Replace one-element array with flexible-array member Gustavo A. R. Silva
2021-08-09 21:24 ` Brian Norris [this message]
2021-08-09 21:32   ` Gustavo A. R. Silva
2021-08-21 17:50 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).