Netdev Archive on
help / color / mirror / Atom feed
* [PATCH net] net/packet: Fix a comment about hard_header_len and headroom allocation
@ 2020-09-06  3:18 Xie He
  2020-09-07  9:40 ` Willem de Bruijn
  0 siblings, 1 reply; 6+ messages in thread
From: Xie He @ 2020-09-06  3:18 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Willem de Bruijn, John Ogness,
	Mao Wenan, Eric Dumazet, Or Cohen, Arnd Bergmann, Xie He, netdev,
  Cc: Willem de Bruijn, Eric Dumazet, Brian Norris, Cong Wang

This comment is outdated and no longer reflects the actual implementation
of af_packet.c.

Reasons for the new comment:


In this file, the function packet_snd first reserves a headroom of
length (dev->hard_header_len + dev->needed_headroom).
Then if the socket is a SOCK_DGRAM socket, it calls dev_hard_header,
which calls dev->header_ops->create, to create the link layer header.
If the socket is a SOCK_RAW socket, it "un-reserves" a headroom of
length (dev->hard_header_len), and checks if the user has provided a
header of length (dev->hard_header_len) (in dev_validate_header).
This shows the developers of af_packet.c expect hard_header_len to
be consistent with header_ops.


In this file, the function packet_sendmsg_spkt has a FIXME comment.
That comment states that prepending an LL header internally in a driver
is considered a bug. I believe this bug can be fixed by setting
hard_header_len to 0, making the internal header completely invisible
to af_packet.c (and requesting the headroom in needed_headroom instead).


There is a commit for a WiFi driver:
commit 9454f7a895b8 ("mwifiex: set needed_headroom, not hard_header_len")
According to the discussion about it at:
The author tried to set the WiFi driver's hard_header_len to the Ethernet
header length, and request additional header space internally needed by
setting needed_headroom. This means this usage is already adopted by
driver developers.

Cc: Willem de Bruijn <>
Cc: Eric Dumazet <>
Cc: Brian Norris <>
Cc: Cong Wang <>
Signed-off-by: Xie He <>
 net/packet/af_packet.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index 2b33e977a905..c808c76efa71 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -93,12 +93,15 @@
-   - if device has no dev->hard_header routine, it adds and removes ll header
-     inside itself. In this case ll header is invisible outside of device,
-     but higher levels still should reserve dev->hard_header_len.
-     Some devices are enough clever to reallocate skb, when header
-     will not fit to reserved space (tunnel), another ones are silly
-     (PPP).
+   - If the device has no dev->header_ops, there is no LL header visible
+     outside of the device. In this case, its hard_header_len should be 0.
+     The device may prepend its own header internally. In this case, its
+     needed_headroom should be set to the space needed for it to add its
+     internal header.
+     For example, a WiFi driver pretending to be an Ethernet driver should
+     set its hard_header_len to be the Ethernet header length, and set its
+     needed_headroom to be (the real WiFi header length - the fake Ethernet
+     header length).
    - packet socket receives packets with pulled ll header,
      so that SOCK_RAW should push it back.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-08 16:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-06  3:18 [PATCH net] net/packet: Fix a comment about hard_header_len and headroom allocation Xie He
2020-09-07  9:40 ` Willem de Bruijn
2020-09-08  0:07   ` Xie He
2020-09-08  8:55     ` Willem de Bruijn
2020-09-08 11:27       ` Xie He
2020-09-08 13:55         ` Willem de Bruijn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).