Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Andrejs Cainikovs <Andrejs.Cainikovs@netmodule.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S . Miller" <davem@davemloft.net>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Patrick Zysset <Patrick.Zysset@netmodule.com>,
	"Federico Rossi (fede.a.rossi@gmail.com)"
	<fede.a.rossi@gmail.com>,
	Max Sonnaillon <Max.Sonnaillon@ppst.com>
Subject: Re: [PATCH 0/2] D_CAN RX buffer size improvements
Date: Wed, 13 Jan 2021 15:43:46 -0300	[thread overview]
Message-ID: <CAAEAJfBWMWuuVebLjURJE=+UtJ8OQxXtEiPWKeQMgQTJ5rivfA@mail.gmail.com> (raw)
In-Reply-To: <20190208132954.28166-1-andrejs.cainikovs@netmodule.com>

Hi everyone,

This series was recently brought to my attention, in connection to a
long-standing
packet drop issue that we had on a Sitara-based product.

I haven't tested this personally, but I've been notified that this was
backported
to the v4.19 kernel, and the packet drop was fixed.

It seems the series never managed to get upstreamed,
but I think this should be resurrected and merged (probably with after
some cleanup/review).

Thanks,
Ezequiel

On Fri, 8 Feb 2019 at 10:31, Andrejs Cainikovs
<Andrejs.Cainikovs@netmodule.com> wrote:
>
> Re-sending entire patchset due to missed cover letter, sorry.
>
> This patchset introduces support for 64 D_CAN message objects with an option of
> unequal split between RX/TX.
>
> The rationale behind this is that there are lots of frame loss on higher bus
> speeds. Below are test results from my custom Sitara AM3352 based board:
>
>   Sender: timeout 15m cangen can0 -g 0 -i x
>   Target: candump can0,0~0,#FFFFFFFF -td -c -d -e
>
>   * Without patches:
>     - 15 minute RX test, 500kbps
>     - 16 RX / 16 TX message objects
>     - 77 received frames lost out of 4649415
>
>   * With patches applied:
>     - 15 hours RX test, 500kbps
>     - 56 RX / 8 TX message objects
>     - 41 received frames lost out of 279303376
>
> Please note, I do not have ability to test pure C_CAN, so it is left untested.
>
> ---
>
> Andrejs Cainikovs (2):
>   can: c_can: support 64 message objects for D_CAN
>   can: c_can: configurable amount of D_CAN RX objects
>
>  drivers/net/can/c_can/Kconfig | 20 ++++++++++
>  drivers/net/can/c_can/c_can.c | 93 +++++++++++++++++++++++++++----------------
>  drivers/net/can/c_can/c_can.h | 20 +++++++---
>  3 files changed, 94 insertions(+), 39 deletions(-)
>
> ---
> 2.11.0
>

  parent reply	other threads:[~2021-01-13 18:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 13:31 [PATCH 0/2] D_CAN RX buffer size improvements Andrejs Cainikovs
2019-02-08 13:31 ` [PATCH 1/2] can: c_can: support 64 message objects for D_CAN Andrejs Cainikovs
2019-02-08 13:31 ` [PATCH 2/2] can: c_can: configurable amount of D_CAN RX objects Andrejs Cainikovs
2021-01-13 18:43 ` Ezequiel Garcia [this message]
2021-08-06 10:16 ` [PATCH 0/2] D_CAN RX buffer size improvements Andrejs Cainikovs
2021-08-06 10:36   ` Marc Kleine-Budde
2021-08-06 13:53     ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAEAJfBWMWuuVebLjURJE=+UtJ8OQxXtEiPWKeQMgQTJ5rivfA@mail.gmail.com' \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=Andrejs.Cainikovs@netmodule.com \
    --cc=Max.Sonnaillon@ppst.com \
    --cc=Patrick.Zysset@netmodule.com \
    --cc=davem@davemloft.net \
    --cc=fede.a.rossi@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).