From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB62C433E7 for ; Tue, 1 Sep 2020 15:10:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 035F620FC3 for ; Tue, 1 Sep 2020 15:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lCL5SLaM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbgIAPKD (ORCPT ); Tue, 1 Sep 2020 11:10:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgIAPJQ (ORCPT ); Tue, 1 Sep 2020 11:09:16 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DFF6C061244 for ; Tue, 1 Sep 2020 08:09:16 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id i26so2131862ejb.12 for ; Tue, 01 Sep 2020 08:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BIr3FRHLWeYI5mpm2jHeXhPihRGMNnmHYOmMOMeHpR4=; b=lCL5SLaMFPqoPftiV2X8nocTTBdKqARvrqI17ufYPS0DtjiIyaSIs4CniiHZ/VEW8n WoqCHbvQzPHbcjvAM7+zD7U98QNr5oxI5U75nYwYeOtUdaj7M9sptx5fdS3otDiC5uUz 5071XY7IwhHNlm+8JmyRZFrwvyyMI1Xxx/Jf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BIr3FRHLWeYI5mpm2jHeXhPihRGMNnmHYOmMOMeHpR4=; b=nzErmjGNpxDK30qucra5zND0RJI8e2/lLyx2b04iLGxt0yztSxzNiE6U2QfTXLRNWh hcDKyW4QkCyTgplRVX/vhdUCNOyTE9ylxV7oVzKr4OhMMFALP6oPABRO7kb1Xu6N9iEX qVXdgAPBxmqR2vBDu2Vr1FWNKgO0EQMiFbfxPew5bZiJylH+/cKfTkC57UnO0GzlhpdV 6zVQDAQxG69r2/43v1IJSnhuiNYnKaQF7qNs+mpa4q3yg8dJQvuFC9rgvZymgxzqw2hC nKG4yGysjHg5uq0eln/AFKtEHJhGhwXmpEwyQ47/cH9PThoGD53Oki4H60wPcUVqxWjk Noxw== X-Gm-Message-State: AOAM533BytlIiNbtSyNRsrQ8NvaFCWCWOBuHVu+6XXBKD0MM94tX7VAH fDWFtmQnpcLW1zVK78JMIr/plgeIOh9AZQ== X-Google-Smtp-Source: ABdhPJwK0muIaHdhFduAOnOrHKNBF040tStYHPqxJ3fozJZD6XWSLvliiM9hDW0M9asjwd8s/kkiYg== X-Received: by 2002:a17:906:6c5:: with SMTP id v5mr1782686ejb.323.1598972955017; Tue, 01 Sep 2020 08:09:15 -0700 (PDT) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com. [209.85.221.42]) by smtp.gmail.com with ESMTPSA id d24sm1348879edu.83.2020.09.01.08.09.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 08:09:14 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id w5so1942382wrp.8 for ; Tue, 01 Sep 2020 08:09:14 -0700 (PDT) X-Received: by 2002:a5d:5150:: with SMTP id u16mr2332024wrt.197.1598972568491; Tue, 01 Sep 2020 08:02:48 -0700 (PDT) MIME-Version: 1.0 References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> <20200820044347.GA4533@lst.de> <20200820052004.GA5305@lst.de> <20200820165407.GD12693@lst.de> <20200901110617.GA13232@lst.de> In-Reply-To: <20200901110617.GA13232@lst.de> From: Tomasz Figa Date: Tue, 1 Sep 2020 17:02:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT To: Christoph Hellwig Cc: alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 1, 2020 at 1:06 PM Christoph Hellwig wrote: > > On Thu, Aug 20, 2020 at 07:33:48PM +0200, Tomasz Figa wrote: > > > It wasn't meant to be too insulting, but I found this out when trying > > > to figure out how to just disable it. But it also ends up using > > > the actual dma attr flags for it's own consistency checks, so just > > > not setting the flag did not turn out to work that easily. > > > > > > > Yes, sadly the videobuf2 ended up becoming quite counterintuitive > > after growing for the long years and that is reflected in the design > > of this feature as well. I think we need to do something about it. > > So I'm about to respin the series and wonder how we should proceed. > I've failed to come up with a clean patch to keep the flag and make > it a no-op. Can you or your team give it a spin? > Okay, I'll take a look. > Also I wonder if the flag should be renamed from NON_CONSISTENT > to NON_COHERENT - the consistent thing is a weird wart from the times > the old PCI DMA API that is mostly gone now. It originated from the DMA_ATTR_NON_CONSISTENT flag, but agreed that NON_COHERENT would be more consistent (pun not intended) with the rest of the DMA API given the removal of that flag. Let me see if we can still change it. Best regards, Tomasz