From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E10C433DF for ; Thu, 20 Aug 2020 17:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 146EB207DE for ; Thu, 20 Aug 2020 17:34:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WJVp6uka" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730496AbgHTReN (ORCPT ); Thu, 20 Aug 2020 13:34:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729448AbgHTReE (ORCPT ); Thu, 20 Aug 2020 13:34:04 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63751C061385 for ; Thu, 20 Aug 2020 10:34:04 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id b2so959014edw.5 for ; Thu, 20 Aug 2020 10:34:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=++DU+mGMau0wCVk26WL7BRudLdRoW/TdcNVBaFfSVeo=; b=WJVp6ukadTpNcM9SYJpDROIRN+tD3gRH5NoPQs0+HAsQmLtJTImp5dRFMc7wGC3HgN R/lFt0vUnPt7BGWZ9GyHNRaZ0vNwnvZs2Kqg3u8nexS2ZBfKmw9OlPBaaVZioiS7BHsl YQ4r7w5vrJPUKxgqdugvjbGIbRfRLzSot++CY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=++DU+mGMau0wCVk26WL7BRudLdRoW/TdcNVBaFfSVeo=; b=PmV6eXcZVt7aAgX71TMpb0TS+u4ybQ3LMGVGN2qQSNHn2hc5G13RubKWzSuYJfuVVq 4o+UYrqkvQCeNIIfuB8GJu8oWpOlZ67+hccRR59EKlCIM8UA2q0S1X1gorzn0ENEMsGj HCG7WIjO8lQ12BN0A6snxA6Y2e6lGwLNDFbMwdnF7Jxmidbp1kSJJ4/rU+JPCX5i+nDh MnMIBEUQ2FsKjz4uSig/E7zLv1hfEK7OD+UavbYY1fwa8SEEuWwVMStFGhnDemgmAT7v l2GvtMUgZ/F3z5wPoBZOP6IuqgxWKWHRfRqLCSL80dl6baflVtO1Kn8nHWqDIXA9kkBn 7l0w== X-Gm-Message-State: AOAM531djfo+2r1DQDVrgEUdzzIG3jEt0U1JY/Iqv/nz9wfyhNK8OCAi TQVlAWSC43ffivOYsc+g+l99J9efUO/x5g== X-Google-Smtp-Source: ABdhPJz0zrZ5PDA3Ea1nRfjHqNnZBfbCwQ3sKW8FL+gi54ChAEGdw1btYqr0XlrVl05IO9jiTXQpaA== X-Received: by 2002:a05:6402:1b1c:: with SMTP id by28mr4063182edb.89.1597944843071; Thu, 20 Aug 2020 10:34:03 -0700 (PDT) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com. [209.85.218.41]) by smtp.gmail.com with ESMTPSA id j3sm1666205edd.92.2020.08.20.10.34.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2020 10:34:02 -0700 (PDT) Received: by mail-ej1-f41.google.com with SMTP id kq25so3490319ejb.3 for ; Thu, 20 Aug 2020 10:34:02 -0700 (PDT) X-Received: by 2002:adf:ec4f:: with SMTP id w15mr4013793wrn.385.1597944841643; Thu, 20 Aug 2020 10:34:01 -0700 (PDT) MIME-Version: 1.0 References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-6-hch@lst.de> <20200819135454.GA17098@lst.de> <20200820044347.GA4533@lst.de> <20200820052004.GA5305@lst.de> <20200820165407.GD12693@lst.de> In-Reply-To: <20200820165407.GD12693@lst.de> From: Tomasz Figa Date: Thu, 20 Aug 2020 19:33:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT To: Christoph Hellwig Cc: alsa-devel@alsa-project.org, linux-ia64@vger.kernel.org, Linux Doc Mailing List , nouveau@lists.freedesktop.org, linux-nvme@lists.infradead.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , linux-mm@kvack.org, linux-samsung-soc , Joonyoung Shim , linux-scsi@vger.kernel.org, Kyungmin Park , Ben Skeggs , Matt Porter , Linux Media Mailing List , Tom Lendacky , Pawel Osciak , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, netdev@vger.kernel.org, Seung-Woo Kim , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 20, 2020 at 6:54 PM Christoph Hellwig wrote: > > On Thu, Aug 20, 2020 at 12:05:29PM +0200, Tomasz Figa wrote: > > The UAPI and V4L2/videobuf2 changes are in good shape and the only > > wrong part is the use of DMA API, which was based on an earlier email > > guidance anyway, and a change to the synchronization part . I find > > conclusions like the above insulting for people who put many hours > > into designing and implementing the related functionality, given the > > complexity of the videobuf2 framework and how ill-defined the DMA API > > was, and would feel better if such could be avoided in future > > communication. > > It wasn't meant to be too insulting, but I found this out when trying > to figure out how to just disable it. But it also ends up using > the actual dma attr flags for it's own consistency checks, so just > not setting the flag did not turn out to work that easily. > Yes, sadly the videobuf2 ended up becoming quite counterintuitive after growing for the long years and that is reflected in the design of this feature as well. I think we need to do something about it. > But in general it helps to add a few more people to the Cc list for > such things that do stranger things. Especially if you think you did > it based on the advice of those people. Indeed, we should have CCed you and other DMA folks. Sergey who worked on this series is quite new to these areas of the kernel (although not to the kernel itself) and it's my fault for not explicitly letting him know to do that. Best regards, Tomasz