Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Aleksander Morgado <aleksander@aleksander.es>
To: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Cc: "Bjørn Mork" <bjorn@mork.no>, "Daniele Palmas" <dnlplm@gmail.com>,
	"Network Development" <netdev@vger.kernel.org>,
	"Sean Tranchetti" <stranche@codeaurora.org>
Subject: Re: RMNET QMAP data aggregation with size greater than 16384
Date: Fri, 6 Aug 2021 16:08:45 +0200	[thread overview]
Message-ID: <CAAP7ucJRbg58Yqcx-qFFUuu=_=3Ss1HE1ZW4XGrm0KsSXnwdmA@mail.gmail.com> (raw)
In-Reply-To: <77b850933d9af8ddbc21f5908ca0764d@codeaurora.org>

Hey Subash,

> > I may be mistaken then in how this should be setup when using rmnet.
> > For the qmi_wwan case using add_mux/del_mux (Daniele correct me if
> > wrong!), we do need to configure the MTU of the master interface to be
> > equal to the aggregation data size reported via QMI WDA before
> > creating any mux link; see
> > http://paldan.altervista.org/linux-qmap-qmi_wwan-multiple-pdn-setup/
> >
> > I ended up doing the same here for the rmnet case; but if it's not
> > needed I can definitely change that. I do recall that I originally had
> > left the master MTU untouched in the rmnet case and users had issues,
> > and increasing it to the aggregation size solved that; I assume that's
> > because the MTU should have been increased to accommodate the extra
> > MAP header as you said. How much more size does it need on top of the
> > 1500 bytes?
>
> You need to use an additional 4 bytes for MAPv1 and 8 bytes for
> MAPv4/v5.
>

I tried with a SIMCOM 7600E, with data aggregation enabled with QMAPv1:

$ sudo qmicli -d /dev/cdc-wdm0 -p --wda-get-data-format
[/dev/cdc-wdm0] Successfully got data format
                   QoS flow header: no
               Link layer protocol: 'raw-ip'
  Uplink data aggregation protocol: 'qmap'
Downlink data aggregation protocol: 'qmap'
                     NDP signature: '0'
Downlink data aggregation max datagrams: '10'
Downlink data aggregation max size: '4096'

As you suggested, the MTU of the new muxed interface is set to 1500
and the MTU of the master interface to only 4 more bytes (1504):

# ip link
8: wwp0s20f0u8u4i5: <POINTOPOINT,UP,LOWER_UP> mtu 1504 qdisc fq_codel
state UNKNOWN mode DEFAULT group default qlen 1000
    link/none
9: qmapmux0.0@wwp0s20f0u8u4i5: <UP,LOWER_UP> mtu 1500 qdisc fq_codel
state UNKNOWN mode DEFAULT group default qlen 1000
    link/[519]

Under this scenario, the downlink is completely broken (speedtest
0.39Mbps), while the uplink seems to work (speedtest 13Mbps).

If I use the logic I had before, associating the downlink data
aggregation max size reported by the module to the MTU of the master
interface, same as I had to do when using qmi_wwan add_mux/del_mux,
then it works properly:

# ip link
14: wwp0s20f0u8u4i5: <POINTOPOINT,UP,LOWER_UP> mtu 4096 qdisc fq_codel
state UNKNOWN mode DEFAULT group default qlen 1000
    link/none
15: qmapmux0.0@wwp0s20f0u8u4i5: <UP,LOWER_UP> mtu 1500 qdisc fq_codel
state UNKNOWN mode DEFAULT group default qlen 1000
    link/[519]

Downlink is now 26Mbps and uplink still 13Mbps.

Is there something I'm doing wrong? Or do we really need to do the
same thing as in qmi_wwan add_mux/del_mux; i.e. configuring the master
interface MTU to be the same as the downlink max aggregation data size
so that we change the rx_urb_size?

-- 
Aleksander
https://aleksander.es

  reply	other threads:[~2021-08-06 14:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 22:45 Aleksander Morgado
2021-08-05 19:10 ` subashab
2021-08-05 20:32   ` Aleksander Morgado
     [not found]     ` <CAGRyCJHYkH4_FvTzk7BFwjMN=iOTN_Y2=4ueY=s3rJMQO9j7uw@mail.gmail.com>
2021-08-05 21:01       ` Aleksander Morgado
2021-08-05 21:12         ` Daniele Palmas
2021-08-05 22:57     ` subashab
2021-08-06 14:08       ` Aleksander Morgado [this message]
2021-08-06 18:42         ` subashab
2021-08-06 19:58           ` Bjørn Mork
2021-08-06 20:22             ` Aleksander Morgado
2021-08-06 22:30               ` subashab
2021-08-07 10:55                 ` Bjørn Mork
2021-08-09 21:40                   ` subashab
2021-08-12 12:02                     ` Daniele Palmas
2021-08-13  6:21                       ` subashab
2021-08-13  6:25                         ` Bjørn Mork
2021-09-03 13:55                           ` Daniele Palmas
2021-09-08  6:21                             ` subashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAP7ucJRbg58Yqcx-qFFUuu=_=3Ss1HE1ZW4XGrm0KsSXnwdmA@mail.gmail.com' \
    --to=aleksander@aleksander.es \
    --cc=bjorn@mork.no \
    --cc=dnlplm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    --subject='Re: RMNET QMAP data aggregation with size greater than 16384' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).