Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Aleksander Morgado <aleksander@aleksander.es>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,
	Daniele Palmas <dnlplm@gmail.com>,
	Network Development <netdev@vger.kernel.org>,
	Sean Tranchetti <stranche@codeaurora.org>
Subject: Re: RMNET QMAP data aggregation with size greater than 16384
Date: Fri, 6 Aug 2021 22:22:02 +0200	[thread overview]
Message-ID: <CAAP7ucLDFPMG08syrcnKKrX-+MS4_-tpPzZSfMOD6_7G-zq4gQ@mail.gmail.com> (raw)
In-Reply-To: <87bl6aqrat.fsf@miraculix.mork.no>

Hey,

> > The summary of the thread was to set a large rx_urb_size during probe
> > itself for qmi_wwan.
>
> Yes, I think it would be good to make the driver DTRT automatically.
> Coding driver specific quirks into ModemManager might work, but it feels
> wrong to work around a Linux driver bug. We don't have to do that.  We
> can fix the driver.
>
> > https://patchwork.kernel.org/project/linux-usb/patch/20200803065105.8997-1-yzc666@netease.com/
> >
> > We could try setting a large value as suggested there and it should
> > hopefully
> > solve the issue you are seeing.
>
> Why can't we break the rx_urb_size dependency on MTU automatically when
> pass_through or qmi_wwan internal muxing is enabled? Preferably with
> some fixed default size which would Just Work for everyone.
>

That default fixed size you're suggesting for the rx_urb_size, isn't
it supposed to have the same logical meaning as RMNET_MAX_PACKET_SIZE
at the end?

-- 
Aleksander
https://aleksander.es

  reply	other threads:[~2021-08-06 20:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 22:45 Aleksander Morgado
2021-08-05 19:10 ` subashab
2021-08-05 20:32   ` Aleksander Morgado
     [not found]     ` <CAGRyCJHYkH4_FvTzk7BFwjMN=iOTN_Y2=4ueY=s3rJMQO9j7uw@mail.gmail.com>
2021-08-05 21:01       ` Aleksander Morgado
2021-08-05 21:12         ` Daniele Palmas
2021-08-05 22:57     ` subashab
2021-08-06 14:08       ` Aleksander Morgado
2021-08-06 18:42         ` subashab
2021-08-06 19:58           ` Bjørn Mork
2021-08-06 20:22             ` Aleksander Morgado [this message]
2021-08-06 22:30               ` subashab
2021-08-07 10:55                 ` Bjørn Mork
2021-08-09 21:40                   ` subashab
2021-08-12 12:02                     ` Daniele Palmas
2021-08-13  6:21                       ` subashab
2021-08-13  6:25                         ` Bjørn Mork
2021-09-03 13:55                           ` Daniele Palmas
2021-09-08  6:21                             ` subashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAP7ucLDFPMG08syrcnKKrX-+MS4_-tpPzZSfMOD6_7G-zq4gQ@mail.gmail.com \
    --to=aleksander@aleksander.es \
    --cc=bjorn@mork.no \
    --cc=dnlplm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    --subject='Re: RMNET QMAP data aggregation with size greater than 16384' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).