Netdev Archive on
help / color / mirror / Atom feed
From: David Gow <>
To: "José Aquiles Guedes de Rezende" <>
Cc: Jiri Pirko <>, Networking <>,
	Linux Kernel Mailing List <>,
	Brendan Higgins <>,
	Daniel Latypov <>,
	Matheus Henrique de Souza Silva 
Subject: Re: [PATCH] lib: use of kunit in test_parman.c
Date: Wed, 28 Jul 2021 09:37:38 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Jul 28, 2021 at 7:04 AM José Aquiles Guedes de Rezende
<> wrote:
> Convert the parman test module to use the KUnit test framework.
> This makes thetest clearer by leveraging KUnit's assertion macros
> and test case definitions,as well as helps standardize on a testing framework.
> Co-developed-by: Matheus Henrique de Souza Silva <>
> Signed-off-by: Matheus Henrique de Souza Silva <>
> Signed-off-by: José Aquiles Guedes de Rezende <>
> ---

Thanks for porting this! A few more notes from the KUnit side.

>  lib/test_parman.c | 145 +++++++++++++++++++---------------------------
>  1 file changed, 60 insertions(+), 85 deletions(-)

This seems to be missing changes to lib/Kconfig.debug: you'll want to
modify the TEST_PARMAN config item to
- depend on KUNIT
- only appear if !KUNIT_ALL_TESTS

It might also be nice to:
- select PARMAN (it's otherwise extremely unlikely a config will
actually pick up the test)
- maybe rename TEST_PARMAN to PARMAN_KUNIT_TEST (this is optional,
since this is a port of an existing test, but does make it clearer, so
it really depends on what existing usage looks like)

> diff --git a/lib/test_parman.c b/lib/test_parman.c
> index 35e32243693c..bd5010f0a412 100644
> --- a/lib/test_parman.c
> +++ b/lib/test_parman.c

The rest of this looks okay to me, but you should check out Daniel's
comments in his email, too.

-- David

  parent reply	other threads:[~2021-07-28  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 22:58 José Aquiles Guedes de Rezende
2021-07-28  0:04 ` Daniel Latypov
2021-07-28  1:37 ` David Gow [this message]
2021-07-28  4:46 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \
    --cc=~lkcamp/ \
    --subject='Re: [PATCH] lib: use of kunit in test_parman.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).