Netdev Archive on
help / color / mirror / Atom feed
From: Baptiste Covolato <>
To: Michael Chan <>
Cc: David Christensen <>,
	Michael Chan <>,
	Siva Reddy Kallam <>,
	Prashant Sreedharan <>,
	Netdev <>, Daniel Stodden <>
Subject: Re: rtnl_lock deadlock with tg3 driver
Date: Mon, 31 Aug 2020 12:20:32 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Aug 30, 2020 at 9:58 PM Michael Chan <> wrote:
> On Fri, Aug 28, 2020 at 5:40 PM Baptiste Covolato <> wrote:
> >
> > Hi David, Michael,
> >
> > I am contacting you because I'm experiencing an issue that seems to be
> > awfully close to what David attempted to fix related to the tg3 driver
> > infinite sleep while holding rtnl_lock
> > (
> David's remaining issue was tg3_reset_task() returning failure due to
> some hardware error.  This would leave the driver in a limbo state
> with netif_running() still true, but NAPI not enabled.  This can
> easily lead to a soft lockup with rtnl held when it tries to disable
> NAPI again.
> I think the proper fix is to close the device when tg3_reset_task()
> fails to bring it to a consistent state.  I haven't heard back from
> David in a while, so I will propose a patch to do this in the next
> day.
> Let's see if this patch will also work for you.  Thanks.

Thanks Michael. Looking forward to trying this patch out.

Baptiste Covolato

      reply	other threads:[~2020-08-31 19:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29  0:40 Baptiste Covolato
2020-08-31  4:58 ` Michael Chan
2020-08-31 19:20   ` Baptiste Covolato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \
    --subject='Re: rtnl_lock deadlock with tg3 driver' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).