Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Miller <davem@davemloft.net>,
	Netdev <netdev@vger.kernel.org>,
	olteanv@gmail.com
Subject: Re: [PATCH net-next v3 2/3] bnxt: count packets discarded because of netpoll
Date: Thu, 26 Aug 2021 11:43:58 -0700	[thread overview]
Message-ID: <CACKFLimh-oLG7zNBgSCYqS1aJh5ivBJJK+5kkL1kqJU5NOHctA@mail.gmail.com> (raw)
In-Reply-To: <20210826131224.2770403-3-kuba@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Thu, Aug 26, 2021 at 6:12 AM Jakub Kicinski <kuba@kernel.org> wrote:

> @@ -10646,11 +10653,15 @@ static void bnxt_get_ring_stats(struct bnxt *bp,
>                 stats->multicast += BNXT_GET_RING_STATS64(sw, rx_mcast_pkts);
>
>                 stats->tx_dropped += BNXT_GET_RING_STATS64(sw, tx_error_pkts);
> +
> +               bsw_stats->rx.rx_netpoll_discards +=
> +                       cpr->sw_stats.rx.rx_netpoll_discards;

Can we just add these rx_netpoll_discards counters directly to
stats->rx_dropped?  It looks simpler if we do it that way, right?

>         }
>  }
>
>  static void bnxt_add_prev_stats(struct bnxt *bp,
> -                               struct rtnl_link_stats64 *stats)
> +                               struct rtnl_link_stats64 *stats,
> +                               struct bnxt_sw_stats *bsw_stats)
>  {
>         struct rtnl_link_stats64 *prev_stats = &bp->net_stats_prev;
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

  reply	other threads:[~2021-08-26 18:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 13:12 [PATCH net-next v3 0/3] bnxt: add rx discards stats for oom and netpool Jakub Kicinski
2021-08-26 13:12 ` [PATCH net-next v3 1/3] bnxt: reorder logic in bnxt_get_stats64() Jakub Kicinski
2021-08-26 13:12 ` [PATCH net-next v3 2/3] bnxt: count packets discarded because of netpoll Jakub Kicinski
2021-08-26 18:43   ` Michael Chan [this message]
2021-08-26 19:18     ` Jakub Kicinski
2021-08-26 21:17       ` Michael Chan
2021-08-27  1:15         ` Jakub Kicinski
2021-08-26 13:12 ` [PATCH net-next v3 3/3] bnxt: count discards due to memory allocation errors Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACKFLimh-oLG7zNBgSCYqS1aJh5ivBJJK+5kkL1kqJU5NOHctA@mail.gmail.com \
    --to=michael.chan@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).