On Thu, Aug 26, 2021 at 6:12 AM Jakub Kicinski wrote: > @@ -10646,11 +10653,15 @@ static void bnxt_get_ring_stats(struct bnxt *bp, > stats->multicast += BNXT_GET_RING_STATS64(sw, rx_mcast_pkts); > > stats->tx_dropped += BNXT_GET_RING_STATS64(sw, tx_error_pkts); > + > + bsw_stats->rx.rx_netpoll_discards += > + cpr->sw_stats.rx.rx_netpoll_discards; Can we just add these rx_netpoll_discards counters directly to stats->rx_dropped? It looks simpler if we do it that way, right? > } > } > > static void bnxt_add_prev_stats(struct bnxt *bp, > - struct rtnl_link_stats64 *stats) > + struct rtnl_link_stats64 *stats, > + struct bnxt_sw_stats *bsw_stats) > { > struct rtnl_link_stats64 *prev_stats = &bp->net_stats_prev; >