Netdev Archive on
help / color / mirror / Atom feed
From: Michael Chan <>
To: Jakub Kicinski <>
Cc: David Miller <>,
	Netdev <>,
	Vasundhara Volam <>
Subject: Re: [PATCH net 2/2] bnxt_en: Fix NULL ptr dereference crash in bnxt_fw_reset_task()
Date: Sun, 6 Sep 2020 15:07:02 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, Sep 6, 2020 at 12:25 PM Jakub Kicinski <> wrote:
> devlink can itself scheduler a recovery via:
>   bnxt_fw_fatal_recover() -> bnxt_fw_reset()

Yes, this is how it is initiated when we call devlink_health_report()
to report the error condition.  From bnxt_fw_reset(), we use a
workqueue because we have to go through many states, requiring
sleeping/polling to transition through the states.

> no? Maybe don't make the devlink recovery path need to go via a
> workqueue?

Current implementation is going through a work queue.

  reply	other threads:[~2020-09-06 22:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06  2:55 [PATCH net 0/2] bnxt_en: Two bug fixes Michael Chan
2020-09-06  2:55 ` [PATCH net 1/2] bnxt_en: Avoid sending firmware messages when AER error is detected Michael Chan
2020-09-06  2:55 ` [PATCH net 2/2] bnxt_en: Fix NULL ptr dereference crash in bnxt_fw_reset_task() Michael Chan
2020-09-06 19:25   ` Jakub Kicinski
2020-09-06 22:07     ` Michael Chan [this message]
2020-09-07  3:13       ` Jakub Kicinski
2020-09-07  3:48         ` Michael Chan
2020-09-07 17:13           ` Jakub Kicinski
2020-09-07 17:16 ` [PATCH net 0/2] bnxt_en: Two bug fixes Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).