Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Shiraz Saleem <shiraz.saleem@intel.com>,
	Zhu Yanjun <yanjun.zhu@intel.com>,
	mustafa.ismail@intel.com, Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	RDMA mailing list <linux-rdma@vger.kernel.org>,
	yanjun.zhu@linux.dev, Jakub Kicinski <kuba@kernel.org>,
	linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void
Date: Wed, 14 Jul 2021 17:23:33 +0800	[thread overview]
Message-ID: <CAD=hENfFQD3XnSekpeapr1-vb+xuaJh+qXYGHa2MLAhqWwdcKg@mail.gmail.com> (raw)
In-Reply-To: <YO6rEkoHgsYh+w37@unreal>

On Wed, Jul 14, 2021 at 5:15 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@linux.dev wrote:
> > From: Zhu Yanjun <yanjun.zhu@linux.dev>
> >
> > The function irdma_sc_repost_aeq_entries always returns zero. So
> > the returned type is changed to void.
> >
> > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> > ---
> >  drivers/infiniband/hw/irdma/ctrl.c | 4 +---
> >  drivers/infiniband/hw/irdma/type.h | 3 +--
> >  2 files changed, 2 insertions(+), 5 deletions(-)
>
> <...>
>
> > -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev,
> > -                                                u32 count);
>
> I clearly remember that Jakub asked for more than once to remo remove
> custom ice/irdma error codes. Did it happen? Can we get rid from them
> in RDMA too?

No. This is not related with custom ice/irdma error codes.

This is related with the returned type of the function.
If a function always returns 0, change the function returned type to void.
And remove the related returned value check.

Zhu Yanjun

>
> Thanks

  reply	other threads:[~2021-07-14  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210714031130.1511109-1-yanjun.zhu@linux.dev>
     [not found] ` <20210714031130.1511109-2-yanjun.zhu@linux.dev>
2021-07-14  9:14   ` Leon Romanovsky
2021-07-14  9:23     ` Zhu Yanjun [this message]
2021-07-18  9:27       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=hENfFQD3XnSekpeapr1-vb+xuaJh+qXYGHa2MLAhqWwdcKg@mail.gmail.com' \
    --to=zyjzyj2000@gmail.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mustafa.ismail@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=shiraz.saleem@intel.com \
    --cc=yanjun.zhu@intel.com \
    --cc=yanjun.zhu@linux.dev \
    --subject='Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq_entries to void' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).