Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Coco Li <lixiaoyan@google.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	Willem de Bruijn <willemb@google.com>,
	Tanner Love <tannerlove@google.com>
Subject: Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test
Date: Thu, 5 Aug 2021 13:21:18 -0700	[thread overview]
Message-ID: <CADjXwjimPFM4Ut0Zv0cZh0DviwW=CrAb=XV5zLeX+4d__OayDg@mail.gmail.com> (raw)
In-Reply-To: <6595b716cb0b37e9daf4202163b4567116d4b4e2.camel@redhat.com>

On Thu, Aug 5, 2021 at 4:16 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> Hello,
>
> On Thu, 2021-08-05 at 07:36 +0000, Coco Li wrote:
> > Implement a GRO testsuite that expects Linux kernel GRO behavior.
> > All tests pass with the kernel software GRO stack. Run against a device
> > with hardware GRO to verify that it matches the software stack.
> >
> > gro.c generates packets and sends them out through a packet socket. The
> > receiver in gro.c (run separately) receives the packets on a packet
> > socket, filters them by destination ports using BPF and checks the
> > packet geometry to see whether GRO was applied.
> >
> > gro.sh provides a wrapper to run the gro.c in NIC loopback mode.
> > It is not included in continuous testing because it modifies network
> > configuration around a physical NIC: gro.sh sets the NIC in loopback
> > mode, creates macvlan devices on the physical device in separate
> > namespaces, and sends traffic generated by gro.c between the two
> > namespaces to observe coalescing behavior.
>
> I like this idea a lot!
>
> Have you considered additionally run the same test of top of a veth
> pair, and have such tests always enabled, so we could have some
> coverage regardless of specific H/W available?
>
> To do the above you should disable TSO on the veth sender peer and
> enable GRO on the other end.

Thanks for the suggestion! To make sure I understand you correctly,
would this be another script that creates the veth pair separate from
the gro.sh wrapper?

  reply	other threads:[~2021-08-05 20:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  7:36 [PATCH net-next 0/2] GRO and Toeplitz hash selftests Coco Li
2021-08-05  7:36 ` [PATCH net-next 1/2] selftests/net: GRO coalesce test Coco Li
2021-08-05 11:16   ` Paolo Abeni
2021-08-05 20:21     ` Coco Li [this message]
     [not found]     ` <CADjXwjhvb9BVNPjY2f-4yfE51RGL88U3VbiN_gwaMSGbagzQEg@mail.gmail.com>
2021-08-06  7:49       ` Paolo Abeni
2021-08-06 17:44         ` Coco Li
2021-08-05  7:36 ` [PATCH net-next 2/2] selftests/net: toeplitz test Coco Li
2021-08-05 12:30 ` [PATCH net-next 0/2] GRO and Toeplitz hash selftests patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADjXwjimPFM4Ut0Zv0cZh0DviwW=CrAb=XV5zLeX+4d__OayDg@mail.gmail.com' \
    --to=lixiaoyan@google.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tannerlove@google.com \
    --cc=willemb@google.com \
    --subject='Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).