Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Xin Long <lucien.xin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "network dev" <netdev@vger.kernel.org>,
	davem <davem@davemloft.net>,
	"linux-sctp @ vger . kernel . org" <linux-sctp@vger.kernel.org>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
	"Timo Völker" <timo.voelker@fh-muenster.de>
Subject: Re: [PATCH net 2/2] sctp: send pmtu probe only if packet loss in Search Complete state
Date: Tue, 20 Jul 2021 10:16:12 -0400	[thread overview]
Message-ID: <CADvbK_fhN-kSbntKjmhD-_WJweAduUtHmucuFwLj_ZYYXbb6cA@mail.gmail.com> (raw)
In-Reply-To: <20210720125036.29ed23ba@cakuba>

On Tue, Jul 20, 2021 at 6:50 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 19 Jul 2021 12:53:23 -0400, Xin Long wrote:
> > This patch is to introduce last_rtx_chunks into sctp_transport to detect
> > if there's any packet retransmission/loss happened by checking against
> > asoc's rtx_data_chunks in sctp_transport_pl_send().
> >
> > If there is, namely, transport->last_rtx_chunks != asoc->rtx_data_chunks,
> > the pmtu probe will be sent out. Otherwise, increment the pl.raise_count
> > and return when it's in Search Complete state.
> >
> > With this patch, if in Search Complete state, which is a long period, it
> > doesn't need to keep probing the current pmtu unless there's data packet
> > loss. This will save quite some traffic.
> >
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Can we get a Fixes tag, please?
Fixes: 0dac127c0557 ("sctp: do black hole detection in search complete state")

Should I repost?

      reply	other threads:[~2021-07-20 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 16:53 [PATCH net 0/2] sctp: improve the pmtu probe " Xin Long
2021-07-19 16:53 ` [PATCH net 1/2] sctp: improve the code for pmtu probe send and recv update Xin Long
2021-07-19 16:53 ` [PATCH net 2/2] sctp: send pmtu probe only if packet loss in Search Complete state Xin Long
2021-07-20 10:50   ` Jakub Kicinski
2021-07-20 14:16     ` Xin Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADvbK_fhN-kSbntKjmhD-_WJweAduUtHmucuFwLj_ZYYXbb6cA@mail.gmail.com \
    --to=lucien.xin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=timo.voelker@fh-muenster.de \
    --subject='Re: [PATCH net 2/2] sctp: send pmtu probe only if packet loss in Search Complete state' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).