From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CE3C31E5C for ; Tue, 8 Sep 2020 15:55:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33FE6251C7 for ; Tue, 8 Sep 2020 15:55:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=sslab.ics.keio.ac.jp header.i=@sslab.ics.keio.ac.jp header.b="I49U5h01" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730555AbgIHPxW (ORCPT ); Tue, 8 Sep 2020 11:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730872AbgIHPwh (ORCPT ); Tue, 8 Sep 2020 11:52:37 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5BBDC061797 for ; Tue, 8 Sep 2020 05:02:49 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id t10so18871700wrv.1 for ; Tue, 08 Sep 2020 05:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sslab.ics.keio.ac.jp; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fHKZGBn8DYDZmUzkcQdtFyocASRnUskXF0G0c14zQIY=; b=I49U5h01ldadqbGBSJ+JPwaa/XpVL1RHekltbw+5yb9vJdeb7HlxO2SH/MxU+AXAwy mFX3smUOgYMCiRiMYtlhJgNbB0x45bfB59AcCGTmRd7oJw5HUypGbJ+wDCYeJroaA4or rnyPXVVdanOQ2bOVqv7iQHTy8xceM8lkCF844= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fHKZGBn8DYDZmUzkcQdtFyocASRnUskXF0G0c14zQIY=; b=bF2wY3jYC1fbzhTyUkxlQTMd8iJ16DeWvvkH+BreoJKVwkJR91UNQaMmKdbWTgIYGd NNu07BeKNk50Uv68ETXaYC5yNEpv08RxD0dkexQE8Cy/2dnnl6rMRKds6xyMCG+7WSjI RWjTJ+yODeTVdb/4IUuYCEukMlINR2hGGYGFlzMraYRKMXvRgPFmb10U7lSL8LpvL81x 88Cyu1zZmgVz2ldQzXQkex9f0osal276b6WjQKvmonN1zGSTXQFgeLO0KEZlqUHfuh/D 8zS2huncw5wBnJn1xibPQH3g8kxnJr6AvPjWdk3EnElD3nrTsowRBzfglXReXJQujKb5 AGrA== X-Gm-Message-State: AOAM53286iA+Pbaub3W+QMM3KH6TqAIDB+dAmyhfxftj6ssKCsONXivP JYIJzK9HFr+qqeXOHsIia9lDU7YpmVJVAtpn0S8eZw== X-Google-Smtp-Source: ABdhPJxLDgBM+s6ZLA0Xk5AyltkUhSxI4KJM4wlm9qfxvCvlS9XOiwZ2ahmKEQRp2PPZaiGtIw02aY3u8gSTeR+ZTXc= X-Received: by 2002:adf:eecb:: with SMTP id a11mr26936125wrp.356.1599566568481; Tue, 08 Sep 2020 05:02:48 -0700 (PDT) MIME-Version: 1.0 References: <20200908001324.8215-1-keitasuzuki.park@sslab.ics.keio.ac.jp> In-Reply-To: From: Keita Suzuki Date: Tue, 8 Sep 2020 21:02:35 +0900 Message-ID: Subject: Re: [PATCH] brcmsmac: fix memory leak in wlc_phy_attach_lcnphy To: Arend Van Spriel Cc: Takafumi Kubota , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "David S. Miller" , Jakub Kicinski , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , "open list:NETWORKING DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thank you for your comment. I am relatively new to the Linux kernel community, so I am more than happy to receive comments. Please let me know if I'm violating any other rules. > > Signed-off-by: Keita Suzuki > > --- > ... changelog here describing difference between previous patch and this > version. I will re-send the patch with the change log. Thanks, Keita 2020=E5=B9=B49=E6=9C=888=E6=97=A5(=E7=81=AB) 20:18 Arend Van Spriel : > > On 9/8/2020 2:13 AM, Keita Suzuki wrote: > > When wlc_phy_txpwr_srom_read_lcnphy fails in wlc_phy_attach_lcnphy, > > the allocated pi->u.pi_lcnphy is leaked, since struct brcms_phy will be > > freed in the caller function. > > > > Fix this by calling wlc_phy_detach_lcnphy in the error handler of > > wlc_phy_txpwr_srom_read_lcnphy before returning. > > Thanks for resubmitting the patch addressing my comment. For clarity it > is recommended to mark the subject with '[PATCH V2]' and add a ... > > > Signed-off-by: Keita Suzuki > > --- > ... changelog here describing difference between previous patch and this > version. > > Regards, > Arend > --- > > .../net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 +++= - > > 1 file changed, 3 insertions(+), 1 deletion(-)