Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 0/4] libbpf: minimize feature detection (reallocarray, libelf-mmap)
Date: Tue, 18 Aug 2020 18:33:15 -0700	[thread overview]
Message-ID: <CAEf4BzYbwYLqa4SanVmiSp95=StzNDkjPSvwjMwABdLEojqwzA@mail.gmail.com> (raw)
In-Reply-To: <CAADnVQLw6a7VKWVhUhNtYWjaOKUhAhLT8nzqHnFAm4nnCUzQkA@mail.gmail.com>

On Tue, Aug 18, 2020 at 6:25 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Aug 18, 2020 at 6:24 PM Andrii Nakryiko <andriin@fb.com> wrote:
> >
> > Get rid of two feature detectors: reallocarray and libelf-mmap. Optional
> > feature detections complicate libbpf Makefile and cause more troubles for
> > various applications that want to integrate libbpf as part of their build.
> >
> > Patch #1 replaces all reallocarray() uses into libbpf-internal reallocarray()
> > implementation. Patches #2 and #3 makes sure we won't re-introduce
> > reallocarray() accidentally. Patch #2 also removes last use of
> > libbpf_internal.h header inside bpftool. There is still nlattr.h that's used
> > by both libbpf and bpftool, but that's left for a follow up patch to split.
> > Patch #4 removed libelf-mmap feature detector and all its uses, as it's
> > trivial to handle missing mmap support in libbpf, the way objtool has been
> > doing it for a while.
> >
> > v1->v2:
> >   - rebase to latest bpf-next (Alexei).
>
> still no good. pls rebase again.

can't keep up :) rebasing

      reply	other threads:[~2020-08-19  1:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  1:21 Andrii Nakryiko
2020-08-19  1:21 ` [PATCH v2 bpf-next 1/4] libbpf: remove any use of reallocarray() in libbpf Andrii Nakryiko
2020-08-19  1:21 ` [PATCH v2 bpf-next 2/4] tools/bpftool: remove libbpf_internal.h usage in bpftool Andrii Nakryiko
2020-08-19  1:21 ` [PATCH v2 bpf-next 3/4] libbpf: centralize poisoning and poison reallocarray() Andrii Nakryiko
2020-08-19  1:21 ` [PATCH v2 bpf-next 4/4] tools: remove feature-libelf-mmap feature detection Andrii Nakryiko
2020-08-19  1:25 ` [PATCH v2 bpf-next 0/4] libbpf: minimize feature detection (reallocarray, libelf-mmap) Alexei Starovoitov
2020-08-19  1:33   ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzYbwYLqa4SanVmiSp95=StzNDkjPSvwjMwABdLEojqwzA@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v2 bpf-next 0/4] libbpf: minimize feature detection (reallocarray, libelf-mmap)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).