Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Hangbin Liu <haliu@redhat.com>, Martynas Pumputis <m@lambda.lt>,
	Networking <netdev@vger.kernel.org>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH iproute2] libbpf: fix attach of prog with multiple sections
Date: Fri, 23 Jul 2021 17:25:25 -0700	[thread overview]
Message-ID: <CAEf4Bza3gMzfSQcv_QDzVP=vsCzxy=8DHwU-EVqOt8XagK7OHw@mail.gmail.com> (raw)
In-Reply-To: <0cc404df-078a-686e-c5ce-8473c0e220f5@gmail.com>

On Fri, Jul 23, 2021 at 5:12 PM David Ahern <dsahern@gmail.com> wrote:
>
> On 7/22/21 10:51 PM, Andrii Nakryiko wrote:
> > On Thu, Jul 22, 2021 at 9:41 PM Hangbin Liu <haliu@redhat.com> wrote:
> >>
> >> On Wed, Jul 21, 2021 at 04:47:14PM +0200, Martynas Pumputis wrote:
> >>>>> diff --git a/lib/bpf_libbpf.c b/lib/bpf_libbpf.c
> >>>>> index d05737a4..f76b90d2 100644
> >>>>> --- a/lib/bpf_libbpf.c
> >>>>> +++ b/lib/bpf_libbpf.c
> >>>>> @@ -267,10 +267,12 @@ static int load_bpf_object(struct bpf_cfg_in *cfg)
> >>>>>          }
> >>>>>
> >>>>>          bpf_object__for_each_program(p, obj) {
> >>>>> +               bool prog_to_attach = !prog && cfg->section &&
> >>>>> +                       !strcmp(get_bpf_program__section_name(p), cfg->section);
> >>>>
> >>>> This is still problematic, because one section can have multiple BPF
> >>>> programs. I.e., it's possible two define two or more XDP BPF programs
> >>>> all with SEC("xdp") and libbpf works just fine with that. I suggest
> >>>> moving users to specify the program name (i.e., C function name
> >>>> representing the BPF program). All the xdp_mycustom_suffix namings are
> >>>> a hack and will be rejected by libbpf 1.0, so it would be great to get
> >>>> a head start on fixing this early on.
> >>>
> >>> Thanks for bringing this up. Currently, there is no way to specify a
> >>> function name with "tc exec bpf" (only a section name via the "sec" arg). So
> >>> probably, we should just add another arg to specify the function name.
> >>
> >> How about add a "prog" arg to load specified program name and mark
> >> "sec" as not recommended? To keep backwards compatibility we just load the
> >> first program in the section.
> >
> > Why not error out if there is more than one program with the same
> > section name? if there is just one (and thus section name is still
> > unique) -- then proceed. It seems much less confusing, IMO.
> >
>
> Let' see if I understand this correctly: libbpf 1.0 is not going to
> allow SEC("xdp_foo") or SEC("xdp_bar") kind of section names - which is
> the hint for libbpf to know program type. Instead only SEC("xdp") is
> allowed.

Right.

>
> Further, a single object file is not going to be allowed to have
> multiple SEC("xdp") instances for each program name.

On the contrary. Libbpf already allows (and will keep allowing)
multiple BPF programs with SEC("xdp") in a single object file. Which
is why section_name is not a unique program identifier.

>
> Correct? If so, it seems like this is limiting each object file to a
> single XDP program or a single object file can have 1 XDP program and 1
> tc program.

  reply	other threads:[~2021-07-24  0:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 12:43 Martynas Pumputis
2021-07-06  2:44 ` Hangbin Liu
2021-07-20 20:27 ` Andrii Nakryiko
2021-07-21 14:47   ` Martynas Pumputis
2021-07-21 14:59     ` David Ahern
2021-07-21 15:27       ` Martynas Pumputis
2021-07-23  4:01         ` Andrii Nakryiko
2021-07-23  4:41     ` Hangbin Liu
2021-07-23  4:51       ` Andrii Nakryiko
2021-07-23  7:55         ` Hangbin Liu
2021-07-23 16:09           ` Andrii Nakryiko
2021-07-24  8:12             ` Hangbin Liu
2021-07-24  0:12         ` David Ahern
2021-07-24  0:25           ` Andrii Nakryiko [this message]
2021-07-26 13:58             ` David Ahern
2021-07-26 15:13               ` Andrii Nakryiko
2021-07-27  2:51                 ` David Ahern
2021-07-27 19:05                   ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4Bza3gMzfSQcv_QDzVP=vsCzxy=8DHwU-EVqOt8XagK7OHw@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@gmail.com \
    --cc=haliu@redhat.com \
    --cc=m@lambda.lt \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --subject='Re: [PATCH iproute2] libbpf: fix attach of prog with multiple sections' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).