Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Juhee Kang <claudiajkang@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument
Date: Mon, 26 Jul 2021 13:08:43 -0700	[thread overview]
Message-ID: <CAEf4Bzb-9TKKdL4x4UYw8T925pASYjt3+29+0xXq-reNG3qy8A@mail.gmail.com> (raw)
In-Reply-To: <20210724152124.9762-1-claudiajkang@gmail.com>

On Sat, Jul 24, 2021 at 8:21 AM Juhee Kang <claudiajkang@gmail.com> wrote:
>
> The current behavior of 'tracex7' doesn't consist with other bpf samples
> tracex{1..6}. Other samples do not require any argument to run with, but
> tracex7 should be run with btrfs device argument. (it should be executed
> with test_override_return.sh)
>
> Currently, tracex7 doesn't have any description about how to run this
> program and raises an unexpected error. And this result might be
> confusing since users might not have a hunch about how to run this
> program.
>
>     // Current behavior
>     # ./tracex7
>     sh: 1: Syntax error: word unexpected (expecting ")")
>     // Fixed behavior
>     # ./tracex7
>     ERROR: Run with the btrfs device argument!
>
> In order to fix this error, this commit adds logic to report a message
> and exit when running this program with a missing argument.
>
> Additionally in test_override_return.sh, there is a problem with
> multiple directory(tmpmnt) creation. So in this commit adds a line with
> removing the directory with every execution.
>
> Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
> ---
>  samples/bpf/test_override_return.sh | 1 +
>  samples/bpf/tracex7_user.c          | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/samples/bpf/test_override_return.sh b/samples/bpf/test_override_return.sh
> index e68b9ee6814b..6480b55502c7 100755
> --- a/samples/bpf/test_override_return.sh
> +++ b/samples/bpf/test_override_return.sh
> @@ -1,5 +1,6 @@
>  #!/bin/bash
>
> +rm -rf tmpmnt

Do we need -rf or -r would do?

>  rm -f testfile.img
>  dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1
>  DEVICE=$(losetup --show -f testfile.img)
> diff --git a/samples/bpf/tracex7_user.c b/samples/bpf/tracex7_user.c
> index fdcd6580dd73..8be7ce18d3ba 100644
> --- a/samples/bpf/tracex7_user.c
> +++ b/samples/bpf/tracex7_user.c
> @@ -14,6 +14,11 @@ int main(int argc, char **argv)
>         int ret = 0;
>         FILE *f;
>
> +       if (!argv[1]) {
> +               fprintf(stderr, "ERROR: Run with the btrfs device argument!\n");
> +               return 0;
> +       }
> +
>         snprintf(filename, sizeof(filename), "%s_kern.o", argv[0]);
>         obj = bpf_object__open_file(filename, NULL);
>         if (libbpf_get_error(obj)) {
> --
> 2.27.0
>

  parent reply	other threads:[~2021-07-26 20:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 15:21 [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Juhee Kang
2021-07-24 15:21 ` [bpf-next 2/2] samples: bpf: Add the omitted xdp samples to .gitignore Juhee Kang
2021-07-26  2:34   ` Yonghong Song
2021-07-26  2:34 ` [bpf-next 1/2] samples: bpf: Fix tracex7 error raised on the missing argument Yonghong Song
2021-07-26 20:08 ` Andrii Nakryiko [this message]
2021-07-27  3:32   ` Juhee Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4Bzb-9TKKdL4x4UYw8T925pASYjt3+29+0xXq-reNG3qy8A@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=claudiajkang@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).