Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 0/5] Add libbpf support for type- and enum value-based CO-RE relocations
Date: Wed, 19 Aug 2020 15:37:39 -0700	[thread overview]
Message-ID: <CAEf4BzbOo9OXj0tkv=BGY0fGKxRRONxG9TmKcspbpWnL22rMLA@mail.gmail.com> (raw)
In-Reply-To: <20200819215846.frvsnoxu6vv4wamt@ast-mbp.dhcp.thefacebook.com>

On Wed, Aug 19, 2020 at 2:58 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Wed, Aug 19, 2020 at 12:45:14PM -0700, Andrii Nakryiko wrote:
> >
> > Selftests are added for all the new features. Selftests utilizing new Clang
> > built-ins are designed such that they will compile with older Clangs and will
> > be skipped during test runs. So this shouldn't cause any build and test
> > failures on systems with slightly outdated Clang compiler.
> >
> > LLVM patches adding these relocation in Clang:
> >   - __builtin_btf_type_id() ([0], [1], [2]);
> >   - __builtin_preserve_type_info(), __builtin_preserve_enum_value() ([3], [4]).
> >
> >   [0] https://reviews.llvm.org/D74572
> >   [1] https://reviews.llvm.org/D74668
> >   [2] https://reviews.llvm.org/D85174
> >   [3] https://reviews.llvm.org/D83878
> >   [4] https://reviews.llvm.org/D83242
>
> Applied.

Thanks!

> Thank you for listing the above in the commit log, but please follow up with
> corresponding update to README.rst and mention the same details there: the
> symptoms of missing clang features, which tests are going to be skipped for
> older clang, etc.

Ok, sure.

>
> Also progs/test_core_reloc_type_id.c talks about some bug with
> __builtin_preserve_type_info() please add llvm diff number that fixes
> it to that .c file.

Ok, that's [2] above.

      reply	other threads:[~2020-08-19 22:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19 19:45 Andrii Nakryiko
2020-08-19 19:45 ` [PATCH v3 bpf-next 1/5] libbpf: implement type-based CO-RE relocations support Andrii Nakryiko
2020-08-19 19:45 ` [PATCH v3 bpf-next 2/5] selftests/bpf: test TYPE_EXISTS and TYPE_SIZE CO-RE relocations Andrii Nakryiko
2020-08-19 19:45 ` [PATCH v3 bpf-next 3/5] selftests/bpf: add CO-RE relo test for TYPE_ID_LOCAL/TYPE_ID_TARGET Andrii Nakryiko
2020-08-19 19:45 ` [PATCH v3 bpf-next 4/5] libbpf: implement enum value-based CO-RE relocations Andrii Nakryiko
2020-08-19 19:45 ` [PATCH v3 bpf-next 5/5] selftests/bpf: add tests for ENUMVAL_EXISTS/ENUMVAL_VALUE relocations Andrii Nakryiko
2020-08-19 21:58 ` [PATCH v3 bpf-next 0/5] Add libbpf support for type- and enum value-based CO-RE relocations Alexei Starovoitov
2020-08-19 22:37   ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzbOo9OXj0tkv=BGY0fGKxRRONxG9TmKcspbpWnL22rMLA@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v3 bpf-next 0/5] Add libbpf support for type- and enum value-based CO-RE relocations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).