Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniele Palmas <dnlplm@gmail.com>
To: Aleksander Morgado <aleksander@aleksander.es>
Cc: "Subash Abhinov Kasiviswanathan" <subashab@codeaurora.org>,
	"Bjørn Mork" <bjorn@mork.no>,
	"Network Development" <netdev@vger.kernel.org>,
	"Sean Tranchetti" <stranche@codeaurora.org>
Subject: Re: RMNET QMAP data aggregation with size greater than 16384
Date: Thu, 5 Aug 2021 23:12:46 +0200	[thread overview]
Message-ID: <CAGRyCJEOZbJNUA1wcm6dGriFkBX+UL8x9ioqTjO45pBf4uBOjA@mail.gmail.com> (raw)
In-Reply-To: <CAAP7ucJhO9E3vzM2-w8V6a5K07_nDQS_V6G78FMWQb-74pRbSQ@mail.gmail.com>

Il giorno gio 5 ago 2021 alle ore 23:01 Aleksander Morgado
<aleksander@aleksander.es> ha scritto:
>
> >> > > I'm playing with the whole QMAP data aggregation setup with a USB
> >> > > connected Fibocom FM150-AE module (SDX55).
> >> > > See https://gitlab.freedesktop.org/mobile-broadband/libqmi/-/issues/71
> >> > > for some details on how I tested all this.
> >> > >
> >> > > This module reports a "Downlink Data Aggregation Max Size" of 32768
> >> > > via the "QMI WDA Get Data Format" request/response, and therefore I
> >> > > configured the MTU of the master wwan0 interface with that same value
> >> > > (while in 802.3 mode, before switching to raw-ip and enabling
> >> > > qmap-pass-through in qmi_wwan).
> >> > >
> >> > > When attempting to create a new link using netlink, the operation
> >> > > fails with -EINVAL, and following the code path in the kernel driver,
> >> > > it looks like there is a check in rmnet_vnd_change_mtu() where the
> >> > > master interface MTU is checked against the RMNET_MAX_PACKET_SIZE
> >> > > value, defined as 16384.
> >> > >
> >> > > If I setup the master interface with MTU 16384 before creating the
> >> > > links with netlink, there's no error reported anywhere. The FM150
> >> > > module crashes as soon as I connect it with data aggregation enabled,
> >> > > but that's a different story...
> >> > >
> >> > > Is this limitation imposed by the RMNET_MAX_PACKET_SIZE value still a
> >> > > valid one in this case? Should changing the max packet size to 32768
> >> > > be a reasonable approach? Am I doing something wrong? :)
> >> > >
> >> > > This previous discussion for the qmi_wwan add_mux/del_mux case is
> >> > > relevant:
> >> > > https://patchwork.ozlabs.org/project/netdev/patch/20200909091302.20992-1-dnlplm@gmail.com/..
> >> > > The suggested patch was not included yet in the qmi_wwan driver and
> >> > > therefore the user still needs to manually configure the MTU of the
> >> > > master interface before setting up all the links, but at least there
> >> > > seems to be no maximum hardcoded limit.
> >> > >
> >> > > Cheers!
> >> >
> >> > Hi Aleksander
> >> >
> >> > The downlink data aggregation size shouldn't affect the MTU.
> >> > MTU applies for uplink only and there is no correlation with the
> >> > downlink path.
> >> > Ideally, you should be able to use standard 1500 bytes (+ additional
> >> > size for MAP header)
> >> > for the master device. Is there some specific network which is using
> >> > greater than 1500 for the IP packet itself in uplink.
> >> >
> >>
> >> I may be mistaken then in how this should be setup when using rmnet.
> >> For the qmi_wwan case using add_mux/del_mux (Daniele correct me if
> >> wrong!), we do need to configure the MTU of the master interface to be
> >> equal to the aggregation data size reported via QMI WDA before
> >> creating any mux link; see
> >> http://paldan.altervista.org/linux-qmap-qmi_wwan-multiple-pdn-setup/
> >>
> >
> > Right: it's not for the MTU itself, but for changing the rx_urb_size, since usbnet_change_mtu has that side effect.
> >
>
> I knew there was a reason even if not obvious. Should we fix that rx
> urb size value to 16384 to avoid needing that extra step? Was that
> what you were suggesting in that patch that was never merged?
>

Yes, that was my purpose, but thinking about it twice, I thought it
was not a very good idea.

There are too many modems/hosts/firmware versions combinations, each
one of them with its own bunch of bugs/quirks (daily experienced):
after all I think it's better to have the possibility to have the urb
size configurable (even if through an odd way), than to have it fixed.

Regards,
Daniele

>
> --
> Aleksander
> https://aleksander.es

  reply	other threads:[~2021-08-05 21:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31 22:45 Aleksander Morgado
2021-08-05 19:10 ` subashab
2021-08-05 20:32   ` Aleksander Morgado
     [not found]     ` <CAGRyCJHYkH4_FvTzk7BFwjMN=iOTN_Y2=4ueY=s3rJMQO9j7uw@mail.gmail.com>
2021-08-05 21:01       ` Aleksander Morgado
2021-08-05 21:12         ` Daniele Palmas [this message]
2021-08-05 22:57     ` subashab
2021-08-06 14:08       ` Aleksander Morgado
2021-08-06 18:42         ` subashab
2021-08-06 19:58           ` Bjørn Mork
2021-08-06 20:22             ` Aleksander Morgado
2021-08-06 22:30               ` subashab
2021-08-07 10:55                 ` Bjørn Mork
2021-08-09 21:40                   ` subashab
2021-08-12 12:02                     ` Daniele Palmas
2021-08-13  6:21                       ` subashab
2021-08-13  6:25                         ` Bjørn Mork
2021-09-03 13:55                           ` Daniele Palmas
2021-09-08  6:21                             ` subashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGRyCJEOZbJNUA1wcm6dGriFkBX+UL8x9ioqTjO45pBf4uBOjA@mail.gmail.com \
    --to=dnlplm@gmail.com \
    --cc=aleksander@aleksander.es \
    --cc=bjorn@mork.no \
    --cc=netdev@vger.kernel.org \
    --cc=stranche@codeaurora.org \
    --cc=subashab@codeaurora.org \
    --subject='Re: RMNET QMAP data aggregation with size greater than 16384' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).