Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: David Miller <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] wwan: core: Fix missing RTM_NEWLINK event for default link
Date: Thu, 22 Jul 2021 21:35:19 +0300	[thread overview]
Message-ID: <CAHNKnsQTqy5qUcjxfC6jKMjduX9AfYq75Ni=8jtNmNvvPob7qQ@mail.gmail.com> (raw)
In-Reply-To: <1626978065-5239-1-git-send-email-loic.poulain@linaro.org>

On Thu, Jul 22, 2021 at 9:10 PM Loic Poulain <loic.poulain@linaro.org> wrote:
> A wwan link created via the wwan_create_default_link procedure is
> never notified to the user (RTM_NEWLINK), causing issues with user
> tools relying on such event to track network links (NetworkManager).
>
> This is because the procedure misses a call to rtnl_configure_link(),
> which sets the link as initialized and notifies the new link (cf
> proper usage in __rtnl_newlink()).
>
> Cc: stable@vger.kernel.org
> Fixes: ca374290aaad ("wwan: core: support default netdev creation")
> Suggested-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

  reply	other threads:[~2021-07-22 18:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 18:21 Loic Poulain
2021-07-22 18:35 ` Sergey Ryazanov [this message]
2021-07-23 16:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHNKnsQTqy5qUcjxfC6jKMjduX9AfYq75Ni=8jtNmNvvPob7qQ@mail.gmail.com' \
    --to=ryazanov.s.a@gmail.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --subject='Re: [PATCH] wwan: core: Fix missing RTM_NEWLINK event for default link' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).