Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Loic Poulain <loic.poulain@linaro.org>,
	"David S. Miller" <davem@davemloft.net>,
	Network Development <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev()
Date: Fri, 6 Aug 2021 12:13:15 +0300	[thread overview]
Message-ID: <CAHNKnsSDX_vRJ7ot1SBfGxcFfd+EoYtdz-fyF66U=t8egmfu9g@mail.gmail.com> (raw)
In-Reply-To: <YQz75yaecp016zOb@smile.fi.intel.com>

Hello Andy,

On Fri, Aug 6, 2021 at 12:08 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Aug 05, 2021 at 09:53:57PM +0200, Loic Poulain wrote:
>> On Thu, 5 Aug 2021 at 20:38, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> wrote:
>>>
>>> wwan_create_dev() is expected to return either valid pointer or NULL,
>>> In some cases it might return the error pointer. Prevent this by converting
>>> it to NULL after wwan_dev_get_by_parent().
>>
>> wwan_create_dev is called both from wwan_register_ops() and
>> wwan_create_port(), one using IS_ERR and the other using NULL testing,
>> they should be aligned as well.
>
> Ah, good catch!
>
> I just sent v2, but eventually I have decided to switch to error pointer since
> it seems the most used pattern in the code.

I agree that returning the error pointer is a good solution here.
Thank you for the fix.

-- 
Sergey

      reply	other threads:[~2021-08-06  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 18:31 Andy Shevchenko
2021-08-05 19:53 ` Loic Poulain
2021-08-06  9:07   ` Andy Shevchenko
2021-08-06  9:13     ` Sergey Ryazanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHNKnsSDX_vRJ7ot1SBfGxcFfd+EoYtdz-fyF66U=t8egmfu9g@mail.gmail.com' \
    --to=ryazanov.s.a@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).