From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602C7C433F5 for ; Tue, 11 Jan 2022 03:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244508AbiAKDnH (ORCPT ); Mon, 10 Jan 2022 22:43:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234316AbiAKDnH (ORCPT ); Mon, 10 Jan 2022 22:43:07 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7A22C06173F for ; Mon, 10 Jan 2022 19:43:06 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id k15so61666333edk.13 for ; Mon, 10 Jan 2022 19:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TdvrBmP0mPwKb4JWkekj6mSFKKSyk8//kkI9lvd2Cu8=; b=NszoFqoF81m1sZRZHjugOzR1aCLA5CWi62KmxDm340AjUvZ1aFYiTySVSXVJLy6Z4i suBPg6ue2xbHsThfyWZ5DsSGU9Fq1IaUsIV+5zYIULmhvPq6JJX0qXMQU8EIGhMKIldI ZybpvkgNZDMgrEtmNL0QNYIHHXs+pS7x8Gp+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TdvrBmP0mPwKb4JWkekj6mSFKKSyk8//kkI9lvd2Cu8=; b=M6EYTdfTmUVGlYTsfp0CANKN6fUiMCdPn5CyQ8Hq2gGQccYtHsB2BkrP8qDeXjDHtU Ps+WbX2m7Krofv9sS4GaoLegeZ8nxJAjqW0/p1S5S2YUBqZDB+yghNJ58hvmdacERCYH szKxfKv/sdRXbAt+Gx/5D74l21vuwbUlSfBrF9k+5OPO1RMh7NC68F5QbU3u+hXC/x5I GwbyE8cbFvbaL4yTuGt/Md1ehiJ8er/rpPILghGTtPUdfuJIq+LXdqYWmIgeV5MgLzHc 6j1RHmM9jwQSi7Z6dWwyHnIa6J7x5REPqPVH1m2TqSVxf3UeAcm45aSORaMg2Fok8Gc2 JX2g== X-Gm-Message-State: AOAM530ASccLq8qOxiKvkwfu5MYRQsARF/QnAAmVDAqiZVItoYOwnWLd 0T2lW0jV/ajWhHFieqaHInGwFExcWtZFceSrHEE= X-Google-Smtp-Source: ABdhPJwZ7eVHyinzgw1ON3W0uNSDayzHzZ7RjYK2qxhQgLSz3Hl591ewwYza74hvRCsNo7/aK5iE7w== X-Received: by 2002:a17:907:7b8e:: with SMTP id ne14mr2071902ejc.259.1641872585317; Mon, 10 Jan 2022 19:43:05 -0800 (PST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com. [209.85.221.45]) by smtp.gmail.com with ESMTPSA id 5sm3068827eji.104.2022.01.10.19.43.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 19:43:04 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id l25so19613716wrb.13 for ; Mon, 10 Jan 2022 19:43:04 -0800 (PST) X-Received: by 2002:adf:f54e:: with SMTP id j14mr2004530wrp.442.1641872584012; Mon, 10 Jan 2022 19:43:04 -0800 (PST) MIME-Version: 1.0 References: <20220110025203.2545903-1-kuba@kernel.org> In-Reply-To: From: Linus Torvalds Date: Mon, 10 Jan 2022 19:42:47 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Networking for 5.17 To: Jakub Kicinski , Thomas Gleixner , Pablo Neira Ayuso Cc: David Miller , Netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 10, 2022 at 7:31 PM Linus Torvalds wrote: > > Merged. But I now note that this actually triggers an error when > building with clang: > > net/netfilter/nf_tables_api.c:8278:4: error: variable 'data_size' is > uninitialized when used here [-Werror,-Wuninitialized] > data_size += sizeof(*prule) + rule->dlen; > ^~~~~~~~~ > > and I think clang is entirely right. I pushed out my trivial one-liner fix for this as commit 63045bfd3c8d ("netfilter: nf_tables: don't use 'data_size' uninitialized"). The build error kept my clang builds from working, so waiting for any alternate fix wasn't going to happen. Linus