Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Björn Töpel" <firstname.lastname@example.org>
To: Li RongQing <email@example.com>
Cc: Netdev <firstname.lastname@example.org>,
"Karlsson, Magnus" <email@example.com>,
"Björn Töpel" <firstname.lastname@example.org>, bpf <email@example.com>,
"Maciej Fijalkowski" <firstname.lastname@example.org>,
Subject: Re: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer
Date: Tue, 18 Aug 2020 16:04:43 +0200 [thread overview]
Message-ID: <CAJ+HfNi2B+2KYP9A7yCfFUhfUBd=sFPeuGbNZMjhNSdq3GEpMg@mail.gmail.com> (raw)
On Fri, 17 Jul 2020 at 08:24, Li RongQing <email@example.com> wrote:
> This fixes ice/i40e/ixgbe/ixgbevf_rx_buffer_flip in
> copy mode xdp that can lead to data corruption.
> I split two patches, since i40e/xgbe/ixgbevf supports xsk
> receiving from 4.18, put their fixes in a patch
Li, sorry for the looong latency. I took a looong vacation. :-P
Thanks for taking a look at this, but I believe this is not a bug.
The Intel Ethernet drivers (obviously non-zerocopy AF_XDP -- "good ol'
XDP") use a page reuse algorithm.
Basic idea is that a page is allocated from the page allocator
(i40e_alloc_mapped_page()). The refcount is increased to
USHRT_MAX. The page is split into two chunks (simplified). If there's
one user of the page, the page can be reused (flipped). If not, a new
page needs to be allocated (with the large refcount).
So, the idea is that usually the page can be reused (flipped), and the
page only needs to be "put" not "get" since the refcount was initally
bumped to a large value.
All frames (except XDP_DROP which can be reused directly) "die" via
page_frag_free() which decreases the page refcount, and frees the page
if the refcount is zero.
Let's take some scenarios as examples:
1. A frame is received in "vanilla" XDP (MEM_TYPE_PAGE_SHARED), and
the XDP program verdict is XDP_TX. The frame will be placed on the
HW Tx ring, and freed* (async) in i40e_clean_tx_irq:
/* free the skb/XDP data */
xdp_return_frame(tx_buf->xdpf); // calls page_frag_free()
2. A frame is passed to the stack, eventually it's freed* via
3. A frame is passed to an AF_XDP socket. The data is copied to the
socket data area, and the frame is directly freed*.
Not the * by the freed. Actually freeing here means calling
page_frag_free(), which means decreasing the refcount. The page reuse
algorithm makes sure that the buffers are not stale.
The only difference from XDP_TX and XDP_DIRECT to dev/cpumaps,
compared to AF_XDP sockets is that the latter calls page_frag_free()
directly, whereas the other does it asynchronous from the Tx clean up
Let me know if it's still not clear, but the bottom line is that none
of these patches are needed.
> Li RongQing (2):
> xdp: i40e: ixgbe: ixgbevf: not flip rx buffer for copy mode xdp
> ice/xdp: not adjust rx buffer for copy mode xdp
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 5 ++++-
> drivers/net/ethernet/intel/ice/ice_txrx.c | 5 ++++-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 ++++-
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 5 ++++-
> include/net/xdp.h | 3 +++
> net/xdp/xsk.c | 4 +++-
> 6 files changed, 22 insertions(+), 5 deletions(-)
> Intel-wired-lan mailing list
next prev parent reply other threads:[~2020-08-18 14:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:24 Li RongQing
2020-07-17 6:24 ` [PATCH 1/2] xdp: i40e: ixgbe: ixgbevf: not flip rx buffer for copy mode xdp Li RongQing
2020-07-20 7:21 ` [Intel-wired-lan] " Magnus Karlsson
2020-07-21 1:42 ` 答复: " Li,Rongqing
2020-07-21 7:49 ` Li,Rongqing
2020-07-17 6:24 ` [PATCH 2/2] ice/xdp: not adjust " Li RongQing
2020-08-18 14:04 ` Björn Töpel [this message]
2020-08-19 1:37 ` 答复: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer Li,Rongqing
2020-08-19 6:44 ` Björn Töpel
2020-08-19 8:17 ` 答复: " Li,Rongqing
2020-08-19 8:31 ` Björn Töpel
2020-08-19 8:52 ` Björn Töpel
2020-08-20 15:13 ` Björn Töpel
2020-08-20 16:51 ` Maciej Fijalkowski
2020-08-20 18:04 ` Björn Töpel
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [Intel-wired-lan] [PATCH 0/2] intel/xdp fixes for fliping rx buffer' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).