From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDEEC4320A for ; Wed, 28 Jul 2021 06:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4A6660EB9 for ; Wed, 28 Jul 2021 06:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233910AbhG1GNH (ORCPT ); Wed, 28 Jul 2021 02:13:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233260AbhG1GNG (ORCPT ); Wed, 28 Jul 2021 02:13:06 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 616B9C061757; Tue, 27 Jul 2021 23:13:05 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id i1so1392155plr.9; Tue, 27 Jul 2021 23:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wyYRguHUYGmijFGDOaM4ez6FDfg83TH7CoepnZpiCFk=; b=YJ/hfPv0PQnc9e1FEROGbS2DAOHUrCBj5EFAhd66H9UW/KrO+8Y6utgNmWsPSU/iLv l5s6pOPkceh4tSnMtluzY1It1p6V/2jWgwzimvkUJPnyp0VhavO8JAaRziTl7yK45pYn 7wQaD+CyjCEARdS7u+epTUFD7xwH9EeqrBORMKvfPXqMAwjDvn+PZLrsjZgXFmTcUy/F +h6zQjMoVi628glO1M/cvrR4BwZpTH7KqoYYu7YeSKPUXQragfmU2puAIjzoaLO/PJAH tX4khBhPdmoPV8bHlnN9CP53GDMhic4QvYOC/ab2pOaX7JOuN6wSaHOTOmMkdN0svdRo Ia5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wyYRguHUYGmijFGDOaM4ez6FDfg83TH7CoepnZpiCFk=; b=O13dh8tycPSyJJL6ym/+MrAKR7QJiaY+xLQqdktlApalkl+QC7vjrecPUVNuaBzTf3 W1GJmr7bt25qaFU7RbtRKPuyb+6Rz/S38XEcia/kR+x9Wr2MGsKKKnx72VhBr3GZzvr5 NMWEuDpbKn8E2cFiU9ypR17+K0MJWeX5JS8YqxprudRw9PweU83cgdkoQbNHyYDW5LDK kMidtS4Up9nUqvhPYo2DAW1GTorWfWvr24IRhOyI7yG/vVGpS3mb3DjauIYZiOlit2/m lRHJPoW96VdcvHO9LWQlR6gObExRL5YtlHWfvSJJT59atZTOXUe0mo2g3z5JeuFFvk/s 8YNA== X-Gm-Message-State: AOAM530CsRIN7Pg3b91C4wrZuFx3kP9Sm7T9uWZHqyBl1Vel+hVzkruj xtaP3sbsaLQgTFnJthzGpjBWWtbiA1sisoC8MzU= X-Google-Smtp-Source: ABdhPJw1njkc66jUGA/LfB7OBpLu4OKubg7+A0Le2fIiT5AsfIZ5sPNvAuJwawC7TTrcvultA/ZZI/v1Uesao9gOjwM= X-Received: by 2002:a17:90a:d58f:: with SMTP id v15mr7933685pju.117.1627452784967; Tue, 27 Jul 2021 23:13:04 -0700 (PDT) MIME-Version: 1.0 References: <20210727131753.10924-1-magnus.karlsson@gmail.com> <20210727131753.10924-2-magnus.karlsson@gmail.com> In-Reply-To: From: Magnus Karlsson Date: Wed, 28 Jul 2021 08:12:54 +0200 Message-ID: Subject: Re: [PATCH bpf-next 01/17] selftests: xsk: remove color mode To: Yonghong Song Cc: "Karlsson, Magnus" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexei Starovoitov , Daniel Borkmann , Network Development , "Fijalkowski, Maciej" , Jonathan Lemon , Ciara Loftus , Jussi Maki , bpf , Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 27, 2021 at 6:43 PM Yonghong Song wrote: > > > > On 7/27/21 6:17 AM, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Remove color mode. > > Could you add some reasoning in the commit message why > removing color mode is a good idea? Will do. The reason is that I do not see color text output adding any value and less code means less of a maintenance burden which is a good thing. But if someone feels that color output is adding value and is using it, I can likely be convinced to keep it. > > > > Signed-off-by: Magnus Karlsson > > --- > > tools/testing/selftests/bpf/test_xsk.sh | 10 +++----- > > tools/testing/selftests/bpf/xsk_prereqs.sh | 27 +++++----------------- > > 2 files changed, 9 insertions(+), 28 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/selftests/bpf/test_xsk.sh > > index 46633a3bfb0b..cd7bf32e6a17 100755 > > --- a/tools/testing/selftests/bpf/test_xsk.sh > > +++ b/tools/testing/selftests/bpf/test_xsk.sh > > @@ -63,14 +63,11 @@ > > # ---------------- > > # Must run with CAP_NET_ADMIN capability. > > # > > -# Run (full color-coded output): > > -# sudo ./test_xsk.sh -c > > +# Run: > > +# sudo ./test_xsk.sh > > # > > # If running from kselftests: > > -# sudo make colorconsole=1 run_tests > > -# > > -# Run (full output without color-coding): > > -# sudo ./test_xsk.sh > > +# sudo make run_tests > [...]