Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Julian Wiedmann <jwi@linux.ibm.com>
Cc: Networking <netdev@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>,
	Karsten Graul <kgraul@linux.ibm.com>,
	linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [PATCH net-next v2 16/31] qeth: use ndo_siocdevprivate
Date: Wed, 21 Jul 2021 10:49:21 +0200	[thread overview]
Message-ID: <CAK8P3a1iOn4pzHXmd+NQnXpmqV9ebF5TdPb7_yUEutkeOgCGtg@mail.gmail.com> (raw)
In-Reply-To: <ef625966-9ff3-5daf-889b-232e420d9e65@linux.ibm.com>

On Wed, Jul 21, 2021 at 8:06 AM Julian Wiedmann <jwi@linux.ibm.com> wrote:
>
> On 20.07.21 17:46, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > qeth has both standard MII ioctls and custom SIOCDEVPRIVATE ones,
> > all of which work correctly with compat user space.
> >
> > Move the private ones over to the new ndo_siocdevprivate callback.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
>
> your get_maintainers scripting seems broken, adding the usual suspects.

Right, I ran the wrong script for sending.

> > -int qeth_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
> > +int qeth_siocdevprivate(struct net_device *dev, struct ifreq *rq, void __user *data, int cmd)
> >  {
> >       struct qeth_card *card = dev->ml_priv;
> > -     struct mii_ioctl_data *mii_data;
> >       int rc = 0;
> >
> >       switch (cmd) {
> >       case SIOC_QETH_ADP_SET_SNMP_CONTROL:
> > -             rc = qeth_snmp_command(card, rq->ifr_ifru.ifru_data);
> > +             rc = qeth_snmp_command(card, data);
> >               break;
> >       case SIOC_QETH_GET_CARD_TYPE:
> >               if ((IS_OSD(card) || IS_OSM(card) || IS_OSX(card)) &&
> >                   !IS_VM_NIC(card))
> >                       return 1;
> >               return 0;
> > +     case SIOC_QETH_QUERY_OAT:
> > +             rc = qeth_query_oat_command(card, data);
> > +             break;
> > +     default:
> > +             if (card->discipline->do_ioctl)
> > +                     rc = card->discipline->do_ioctl(dev, rq, data, cmd);
> > +             else
> > +                     rc = -EOPNOTSUPP;
> > +     }
> > +     if (rc)
> > +             QETH_CARD_TEXT_(card, 2, "ioce%x", rc);
> > +     return rc;
> > +}
> > +EXPORT_SYMBOL_GPL(qeth_siocdevprivate);
> > +
>
> Looks like you missed to wire this up in our netdev_ops structs.

Fixed now, thanks! I've gone through the other patches as well
to see if I made the same mistake elsewhere, but it appears this
one was the only time here.

       Arnd

  reply	other threads:[~2021-07-21  9:02 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 14:46 [PATCH net-next v2 00/31] ndo_ioctl rework Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 01/31] net: split out SIOCDEVPRIVATE handling from dev_ioctl Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 02/31] staging: rtlwifi: use siocdevprivate Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 03/31] staging: wlan-ng: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 04/31] hostap: use ndo_siocdevprivate Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 05/31] bridge: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 06/31] phonet: use siocdevprivate Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 07/31] tulip: use ndo_siocdevprivate Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 08/31] bonding: use siocdevprivate Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 09/31] appletalk: use ndo_siocdevprivate Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 10/31] hamachi: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 11/31] tehuti: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 12/31] eql: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 13/31] fddi: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 14/31] net: usb: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 15/31] slip/plip: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 16/31] qeth: " Arnd Bergmann
2021-07-21  6:05   ` Julian Wiedmann
2021-07-21  8:49     ` Arnd Bergmann [this message]
2021-07-20 14:46 ` [PATCH net-next v2 17/31] cxgb3: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 18/31] hamradio: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 19/31] airo: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 20/31] ip_tunnel: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 21/31] hippi: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 22/31] sb1000: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 23/31] ppp: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 24/31] wan: " Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 25/31] wan: cosa: remove dead cosa_net_ioctl() function Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 26/31] dev_ioctl: pass SIOCDEVPRIVATE data separately Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 27/31] dev_ioctl: split out ndo_eth_ioctl Arnd Bergmann
2021-07-21 16:21   ` Shannon Nelson
2021-07-20 14:46 ` [PATCH net-next v2 28/31] net: split out ndo_siowandev ioctl Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 29/31] net: socket: return changed ifreq from SIOCDEVPRIVATE Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 30/31] net: bridge: move bridge ioctls out of .ndo_do_ioctl Arnd Bergmann
2021-07-20 14:46 ` [PATCH net-next v2 31/31] net: bonding: move ioctl handling to private ndo operation Arnd Bergmann
2021-07-20 19:08 ` [PATCH net-next v2 00/31] ndo_ioctl rework David Miller
2021-07-22 15:02   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a1iOn4pzHXmd+NQnXpmqV9ebF5TdPb7_yUEutkeOgCGtg@mail.gmail.com \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=hch@lst.de \
    --cc=jwi@linux.ibm.com \
    --cc=kgraul@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net-next v2 16/31] qeth: use ndo_siocdevprivate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).