Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH net-next] qed: Handle management FW error
@ 2021-09-09 17:32 Shai Malin
  2021-09-09 21:51 ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Shai Malin @ 2021-09-09 17:32 UTC (permalink / raw)
  To: netdev, davem, kuba; +Cc: aelior, smalin, malin1024

Handle MFW (management FW) error response in order to avoid a crash
during recovery flows.

Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Shai Malin <smalin@marvell.com>
---
 drivers/net/ethernet/qlogic/qed/qed_mcp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
index 6e5a6cc97d0e..24cd41567775 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c
@@ -3367,6 +3367,7 @@ qed_mcp_get_nvm_image_att(struct qed_hwfn *p_hwfn,
 			  struct qed_nvm_image_att *p_image_att)
 {
 	enum nvm_image_type type;
+	int rc;
 	u32 i;
 
 	/* Translate image_id into MFW definitions */
@@ -3395,7 +3396,10 @@ qed_mcp_get_nvm_image_att(struct qed_hwfn *p_hwfn,
 		return -EINVAL;
 	}
 
-	qed_mcp_nvm_info_populate(p_hwfn);
+	rc = qed_mcp_nvm_info_populate(p_hwfn);
+	if (rc)
+		return rc;
+
 	for (i = 0; i < p_hwfn->nvm_info.num_images; i++)
 		if (type == p_hwfn->nvm_info.image_att[i].image_type)
 			break;
-- 
2.22.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] qed: Handle management FW error
  2021-09-09 17:32 [PATCH net-next] qed: Handle management FW error Shai Malin
@ 2021-09-09 21:51 ` Jakub Kicinski
  2021-09-10  8:33   ` Shai Malin
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2021-09-09 21:51 UTC (permalink / raw)
  To: Shai Malin; +Cc: netdev, davem, aelior, malin1024

On Thu, 9 Sep 2021 20:32:22 +0300 Shai Malin wrote:
> Handle MFW (management FW) error response in order to avoid a crash
> during recovery flows.
> 
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Shai Malin <smalin@marvell.com>

Since you say crash I'm assuming this is a fix.

Please repost with a Fixes tag and [PATCH net] in the subject.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] qed: Handle management FW error
  2021-09-09 21:51 ` Jakub Kicinski
@ 2021-09-10  8:33   ` Shai Malin
  0 siblings, 0 replies; 3+ messages in thread
From: Shai Malin @ 2021-09-10  8:33 UTC (permalink / raw)
  To: Jakub Kicinski; +Cc: Shai Malin, netdev, David Miller, Ariel Elior

On Fri, 10 Sept 2021 at 00:51, Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 9 Sep 2021 20:32:22 +0300 Shai Malin wrote:
> > Handle MFW (management FW) error response in order to avoid a crash
> > during recovery flows.
> >
> > Signed-off-by: Ariel Elior <aelior@marvell.com>
> > Signed-off-by: Shai Malin <smalin@marvell.com>
>
> Since you say crash I'm assuming this is a fix.
>
> Please repost with a Fixes tag and [PATCH net] in the subject.

Sure.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-10  8:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 17:32 [PATCH net-next] qed: Handle management FW error Shai Malin
2021-09-09 21:51 ` Jakub Kicinski
2021-09-10  8:33   ` Shai Malin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).