Netdev Archive on
help / color / mirror / Atom feed
From: Steve deRosier <>
To: Mauro Carvalho Chehab <>,
	Kalle Valo <>
	John Stultz <>,
	Manivannan Sadhasivam <>,
	"David S. Miller" <>,
	Jakub Kicinski <>, Maital Hahn <>,
	"Gustavo A. R. Silva" <>,
	Raz Bouganim <>,
	Tony Lindgren <>,
	Dinghao Liu <>,
	Johannes Berg <>,
	Fuqian Huang <>,
	linux-wireless <>,
	Network Development <>,
	LKML <>
Subject: Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"
Date: Thu, 27 Aug 2020 08:48:30 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab
<> wrote:
> This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore:
> with it applied, WiFi stops working, and the Kernel starts printing
> this message every second:
>    wlcore: PHY firmware version: Rev
>    wlcore: firmware booted (Rev
>    wlcore: ERROR command execute failure 14

Only if NO firmware for the device in question supports the `KEY_IGTK`
value, then this revert is appropriate. Otherwise, it likely isn't.
 My suspicion is that the feature that `KEY_IGTK` is enabling is
specific to a newer firmware that Mauro hasn't upgraded to. What the
OP should do is find the updated firmware and give it a try.

AND - since there's some firmware the feature doesn't work with, the
driver should be fixed to detect the running firmware version and not
do things that the firmware doesn't support.  AND the firmware writer
should also make it so the firmware doesn't barf on bad input and
instead rejects it politely.

But I will say I'm making an educated guess; while I have played with
the TI devices in the past, it was years ago and I won't claim to be
an expert. I also am unable to fix it myself at this time.

I'd just rather see it fixed properly instead of a knee-jerk reaction
of reverting it simply because the OP doesn't have current firmware.

And let's revisit the discussion of having a kernel splat because an
unrelated piece of code fails yet the driver does exactly what it is
supposed to do. We shouldn't be dumping registers and stack-trace when
the code that crashed has nothing to do with the registers and
stack-trace outputted. It is a false positive.  A simple printk WARN
or ERROR should output notifying us that the chip firmware has crashed
and why.  IMHO.

- Steve

  parent reply	other threads:[~2020-08-27 15:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26  5:49 Mauro Carvalho Chehab
2020-08-27  8:05 ` Kalle Valo
2020-08-27 15:48 ` Steve deRosier [this message]
2020-08-27 17:42   ` Mauro Carvalho Chehab
2020-08-27 20:36     ` Steve deRosier
2020-08-28  7:44       ` Mauro Carvalho Chehab
2020-08-28  8:31       ` Mauro Carvalho Chehab
2020-08-28  7:41   ` Kalle Valo
2020-09-01  9:31 ` Kalle Valo
     [not found] ` <>
2020-09-01 10:59   ` [EXTERNAL] " Bouganim, Raz
2020-09-01 11:45     ` Kalle Valo
2020-09-07  6:37     ` [PATCH v2] net: wireless: wlcore: fix support for IGTK key Mauro Carvalho Chehab
2020-09-07  7:31       ` [EXTERNAL] " Bouganim, Raz
2020-09-07  8:38 ` [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver" Kalle Valo
2020-09-07  8:40 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Revert "wlcore: Adding suppoprt for IGTK key in wlcore driver"' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).