Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for requeued SKBs
Date: Tue, 13 Jul 2021 10:06:52 +0800 [thread overview]
Message-ID: <CAMDZJNVg0E3SevntjJVm99RdggSxD_oOX=3EXU1v-sQLgDGvNQ@mail.gmail.com> (raw)
In-Reply-To: <CAMDZJNWfRQ_M=6E=jyOSKWMso73nNY1iKw4jyN8JU7NkSyDQcA@mail.gmail.com>
On Mon, Jul 12, 2021 at 12:17 PM Tonghao Zhang <xiangxia.m.yue@gmail.com> wrote:
>
> On Mon, Jul 12, 2021 at 11:51 AM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > On Sat, Jul 10, 2021 at 10:00 PM <xiangxia.m.yue@gmail.com> wrote:
> > >
> > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> > >
> > > The main purpose of this tracepoint is to monitor what,
> > > how many and why packets were requeued. The txq_state can
> > > be used for determining the reason for packets requeued.
> >
> > Hmm, how can I figure out the requeue is caused by
> > validate_xmit_skb_list() when it returns again==true?
Hi cong
Consider this patch again.
The main purpose of this tracepoint is to monitor what, how many and
why packets were requeued.
So should we figure out packets required by validate_xmit_skb_list or
dev_hard_start_xmit ?
because we may want to know what packets were requeued and how many.
if we should figure out, we can add more arg for trace, right ?
> > I fail to see you trace it.
> This patch looks not good.
> > For the other case, we can figure it out by trace_net_dev_xmit().
> > So, in short, your patch looks useless.
> >
> > Thanks.
>
>
>
> --
> Best regards, Tonghao
--
Best regards, Tonghao
next prev parent reply other threads:[~2021-07-13 2:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 5:00 [net-next 1/2] qdisc: add tracepoint qdisc:qdisc_enqueue for enqueued SKBs xiangxia.m.yue
2021-07-11 5:00 ` [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for requeued SKBs xiangxia.m.yue
2021-07-12 3:51 ` Cong Wang
2021-07-12 4:17 ` Tonghao Zhang
2021-07-13 2:06 ` Tonghao Zhang [this message]
2021-07-15 4:24 ` Cong Wang
2021-07-11 18:24 ` [net-next 1/2] qdisc: add tracepoint qdisc:qdisc_enqueue for enqueued SKBs Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMDZJNVg0E3SevntjJVm99RdggSxD_oOX=3EXU1v-sQLgDGvNQ@mail.gmail.com' \
--to=xiangxia.m.yue@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--subject='Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for requeued SKBs' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).