From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AEBC4338F for ; Wed, 4 Aug 2021 17:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A29B860F94 for ; Wed, 4 Aug 2021 17:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239767AbhHDRAY (ORCPT ); Wed, 4 Aug 2021 13:00:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239640AbhHDRAX (ORCPT ); Wed, 4 Aug 2021 13:00:23 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F303DC0613D5 for ; Wed, 4 Aug 2021 10:00:09 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id s22-20020a17090a1c16b0290177caeba067so9707991pjs.0 for ; Wed, 04 Aug 2021 10:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sqIbrRSKxcewBNT00a4KK0eQBLjFurI1/+zQ7attBYA=; b=RhCQOyH5kufck9DSwsk6bWhCQWb21Gzd5BabWRmSKCAlYSiG8+710TjxW+0aFERJtj 6HzPe11AsYAlm85lwLDD82xg88GYG0XXGLQ9v3TWtjurol/LN2ftLeKuI2lntzuRodib l+hq1BWtpaqQAbz5h/C/VdzD7WFZqGtpMuGK/VfGEDNR7AJArBUpn9BplpoGwsKQw8ct AzbVSNWdW8VdxNoH+ZjTZ+8vsDgNOCcm0lZ/uIGZCbkuhU3qAeic+9bHWSsxwbVFdYon 9f3FLrFavyTKzZxa2iGIFJjPU73TSCmqH9BTBIwRUBEUaCNb1TCFELbS0SiB23ofy78T LjWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sqIbrRSKxcewBNT00a4KK0eQBLjFurI1/+zQ7attBYA=; b=MRzGeBC5IeH9AtWwOEors2yxu1JAXlTUdNdp+3aI/rDsszIJVmPNk/rrMS/OLuLcFH AVbgcx4SEFPVNmpXPd8bcHlfHFl/OP+3Qk1wYYYs9D8/4mSg+/pxzE4N0G4Ghtd6RA6z eqPx8BpHiOjnpCdMAhwHXt47D6pJWXr0vRrG6u9MVm0e56niZHURYEUCyVWw202J8v3D UnCORy4KhnBhILqitQSxea/eHfovO/C2YfiqtpZIdX51qf1NePCrmYommI/zT//0KBVq IjIqlWIQ2l/zomFq1Z1DhvFzbuAJohy/ou1pCV0hkUGZWOLNw4cGnmdSpMj8JDDe9vRM IWcA== X-Gm-Message-State: AOAM533x6Pw2B+qw79GNW8Pz/FTa1qO2jfbD0PNZv2x3vuTf5xAtFhtw X5q+DOAjpz40Awu4vVr6ey9PHPMW6TCG+Lxw7eHmZA== X-Google-Smtp-Source: ABdhPJyD/4Kcsvlztp9G6aHU/T9caj1jYYp/DLDeiJWSfXC9AuqoSKxXn91Kc0t1KX4nNGtevdxv3XpSJyjMAziMaM8= X-Received: by 2002:a63:1661:: with SMTP id 33mr88026pgw.443.1628096409551; Wed, 04 Aug 2021 10:00:09 -0700 (PDT) MIME-Version: 1.0 References: <20210804160952.70254-1-m.chetan.kumar@linux.intel.com> <20210804160952.70254-5-m.chetan.kumar@linux.intel.com> In-Reply-To: <20210804160952.70254-5-m.chetan.kumar@linux.intel.com> From: Loic Poulain Date: Wed, 4 Aug 2021 19:09:52 +0200 Message-ID: Subject: Re: [PATCH 4/4] net: wwan: iosm: fix recursive lock acquire in unregister To: M Chetan Kumar Cc: Network Development , Jakub Kicinski , David Miller , Johannes Berg , Sergey Ryazanov , "Sudi, Krishna C" , linuxwwan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 4 Aug 2021 at 18:11, M Chetan Kumar wrote: > > Calling unregister_netdevice() inside wwan del link is trying to > acquire the held lock in ndo_stop_cb(). Instead, queue net dev to > be unregistered later. > > Signed-off-by: M Chetan Kumar Reviewed-by: Loic Poulain