Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Loic Poulain <loic.poulain@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Network Development <netdev@vger.kernel.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Richard Laing <richard.laing@alliedtelesis.co.nz>
Subject: Re: [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver
Date: Mon, 2 Aug 2021 19:22:58 +0200	[thread overview]
Message-ID: <CAMZdPi9ZNU2d+CMKkT3xifOCbTsEeDr6Cj_90Zt3EYW=D6qMqg@mail.gmail.com> (raw)
In-Reply-To: <20210802094054.7bc27154@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Mon, 2 Aug 2021 at 18:40, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon,  2 Aug 2021 09:51:02 +0200 Loic Poulain wrote:
> > Add new wwan driver for MBIM over MHI. MBIM is a transport protocol
> > for IP packets, allowing packet aggregation and muxing. Initially
> > designed for USB bus, it is also exposed through MHI bus for QCOM
> > based PCIe wwan modems.
> >
> > This driver supports the new wwan rtnetlink interface for multi-link
> > management and has been tested with Quectel EM120R-GL M2 module.
>
> Let's make sure it builds cleanly with W=1 C=1 first.

Sure.

>
> drivers/net/wwan/mhi_wwan_mbim.c:83:23: warning: no previous prototype for ‘mhi_mbim_get_link’ [-Wmissing-prototypes]
>    83 | struct mhi_mbim_link *mhi_mbim_get_link(struct mhi_mbim_context *mbim,
>       |                       ^~~~~~~~~~~~~~~~~
> drivers/net/wwan/mhi_wwan_mbim.c:83:22: warning: symbol 'mhi_mbim_get_link' was not declared. Should it be static?
>
> Also - please start putting someone in the To: header, preferably the
> maintainer / mailing list thru which you expect the code to be merged.

Not sure why my `git send-email` keeps ignoring the to field for that
series, but going to fix that, thanks for pointing this.

Regards,
Loic

  reply	other threads:[~2021-08-02 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  7:51 [PATCH net-next RESEND 0/2] net: mhi: move MBIM to WWAN Loic Poulain
2021-08-02  7:51 ` [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver Loic Poulain
2021-08-02 16:40   ` Jakub Kicinski
2021-08-02 17:22     ` Loic Poulain [this message]
2021-08-02  7:51 ` [PATCH net-next RESEND 2/2] net: mhi: Remove MBIM protocol Loic Poulain
2021-08-02 16:40   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMZdPi9ZNU2d+CMKkT3xifOCbTsEeDr6Cj_90Zt3EYW=D6qMqg@mail.gmail.com' \
    --to=loic.poulain@linaro.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richard.laing@alliedtelesis.co.nz \
    --subject='Re: [PATCH net-next RESEND 1/2] net: wwan: Add MHI MBIM network driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).