Netdev Archive on
help / color / mirror / Atom feed
From: Loic Poulain <>
To: Andy Shevchenko <>
Cc: "David S. Miller" <>,
	Sergey Ryazanov <>,
	Network Development <>,
	open list <>,
	Johannes Berg <>,
	Jakub Kicinski <>
Subject: Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev()
Date: Thu, 5 Aug 2021 21:53:57 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, 5 Aug 2021 at 20:38, Andy Shevchenko
<> wrote:
> wwan_create_dev() is expected to return either valid pointer or NULL,
> In some cases it might return the error pointer. Prevent this by converting
> it to NULL after wwan_dev_get_by_parent().

wwan_create_dev is called both from wwan_register_ops() and
wwan_create_port(), one using IS_ERR and the other using NULL testing,
they should be aligned as well.


  reply	other threads:[~2021-08-05 19:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 18:31 Andy Shevchenko
2021-08-05 19:53 ` Loic Poulain [this message]
2021-08-06  9:07   ` Andy Shevchenko
2021-08-06  9:13     ` Sergey Ryazanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v1 1/1] wwan: core: Avoid returning error pointer from wwan_create_dev()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).