From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BBFC432BE for ; Fri, 6 Aug 2021 09:20:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17E8160EE9 for ; Fri, 6 Aug 2021 09:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244305AbhHFJUP (ORCPT ); Fri, 6 Aug 2021 05:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244076AbhHFJUO (ORCPT ); Fri, 6 Aug 2021 05:20:14 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1C67C061798 for ; Fri, 6 Aug 2021 02:19:58 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id u5-20020a17090ae005b029017842fe8f82so7428940pjy.0 for ; Fri, 06 Aug 2021 02:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ygoR1r2IFRYwDwdfhf1sP9OP+NDnxs619rIUX49u2gQ=; b=dR9/17hohzESs+XXHIXIUHUSbpB1dvL5YxWxEVcBo/Mo/QNHMmXZKj2ngnD+5456fo yiU+tPJba+GEHK0mIbiCvUTI8HZQlA1I/aNIdW26rp9ijU+BjyCpjEA1hTGkzl4wYnkM XNSK39RR84QRQynh0i+OGIhb3PhVtvpY34RbP6f4/M5zWYuoOd9N6OClsnMrhEqO6pdk i6pxK4dvKVkahaB3R79D4mSRb9X95nT4ShW3Sy86BWy1BEwpvdLKujfJWUWcNWrS1SG+ lINJdaomQWETHSsP7TyaL9tzOg0gxn8VAZK1GAum/wG/vfHh/0X37T8mNH8WftC58Xwb g3rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ygoR1r2IFRYwDwdfhf1sP9OP+NDnxs619rIUX49u2gQ=; b=JK2R6HmqSAEzmMr/mQAvCZ/ETbtTcMuSwuL9/5lURqq0So8gT4/MEjSPWAi4K8VF7q yLKnwSRn2ty12cMsn9ays8XcCXBC+p6m/i3ZY0tzyXKiBqUCfORdqZiDSXQO1RFCrpaz ob9e4sac7U5P768mfxHDkN2wNSXbaxnlDD5+wVQtU29aoj7Kky7wNzRd4eegzHAS+F5K wBxAJq4YFxhfkCpLKvi64fFQsSRjQFtuJImaAZwVMlYshFHLvxD4s36jdODu1Kpet5ky tCRAu7+7Zi4gRX7OZNhiVZzcdYrhPXEcmevmUpTIpDkNSc93ZVPGlcFsdUPB334fy6gV uojg== X-Gm-Message-State: AOAM531h3XT6AIYEVCbqcikyXkdAvJRS26sowGem8i/octDlfqZ5ZUqo Qo6I4DpYTRQ5exDeJNzjZOq/pv3MglpvehfSe0hnUw== X-Google-Smtp-Source: ABdhPJxr8NrRjjuY9UnDxc8gz+M6TK1vUWssuA+uR8qnEHC2x8bVaPnR6YaXqfIOrKrt8N3O3BqKVAoMDbmvA9pWohw= X-Received: by 2002:a05:6a00:1245:b029:30f:2098:fcf4 with SMTP id u5-20020a056a001245b029030f2098fcf4mr9681880pfi.66.1628241598355; Fri, 06 Aug 2021 02:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> From: Loic Poulain Date: Fri, 6 Aug 2021 11:29:38 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() To: Andy Shevchenko Cc: "David S. Miller" , Sergey Ryazanov , Network Development , open list , Johannes Berg , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 6 Aug 2021 at 11:00, Andy Shevchenko wrote: > > Make wwan_create_dev() to return either valid or error pointer, > In some cases it may return NULL. Prevent this by converting > it to the respective error pointer. > > Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") > Signed-off-by: Andy Shevchenko Reviewed-by: Loic Poulain