Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [net-next 1/2] qdisc: add tracepoint qdisc:qdisc_enqueue for enqueued SKBs
Date: Sun, 11 Jul 2021 11:24:54 -0700	[thread overview]
Message-ID: <CAM_iQpVewx4pDv7BHX0Tf_8px11R31H4jKpLQ+APT3YYcEr=YA@mail.gmail.com> (raw)
In-Reply-To: <20210711050007.1200-1-xiangxia.m.yue@gmail.com>

On Sat, Jul 10, 2021 at 10:00 PM <xiangxia.m.yue@gmail.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> This tracepoint can work with qdisc:qdisc_dequeue to measure
> packets latency in qdisc queue. In some case, for example,
> if TX queues are stopped or frozen, sch_direct_xmit will invoke
> the dev_requeue_skb to requeue SKBs to qdisc->gso_skb, that may
> delay the SKBs in qdisc queue.
>
> With this patch, we can measure packets latency.

Coincidentally, we have a nearly same patch:
https://marc.info/?l=linux-netdev&m=162580785123913&w=2

Also, '%p' certainly does not work, it produces same address for
different packets. This is why we changed it to '%px', see:
https://marc.info/?l=linux-netdev&m=162580784823909&w=2

Thanks.

      parent reply	other threads:[~2021-07-11 18:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-11  5:00 xiangxia.m.yue
2021-07-11  5:00 ` [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for requeued SKBs xiangxia.m.yue
2021-07-12  3:51   ` Cong Wang
2021-07-12  4:17     ` Tonghao Zhang
2021-07-13  2:06       ` Tonghao Zhang
2021-07-15  4:24         ` Cong Wang
2021-07-11 18:24 ` Cong Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpVewx4pDv7BHX0Tf_8px11R31H4jKpLQ+APT3YYcEr=YA@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiangxia.m.yue@gmail.com \
    --subject='Re: [net-next 1/2] qdisc: add tracepoint qdisc:qdisc_enqueue for enqueued SKBs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).