From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEB8C433E2 for ; Tue, 1 Sep 2020 15:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DE11206EB for ; Tue, 1 Sep 2020 15:50:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XZCGQwgw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732011AbgIAPuz (ORCPT ); Tue, 1 Sep 2020 11:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgIAPuh (ORCPT ); Tue, 1 Sep 2020 11:50:37 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51409C061258 for ; Tue, 1 Sep 2020 08:50:31 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id w12so1292988qki.6 for ; Tue, 01 Sep 2020 08:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jV8bljM3lK+GBB6jw/WspxqJuyJuh/lf4f+szOAk3Fw=; b=XZCGQwgwBt860UII5cREakpxcHTR71LTVSlB36D/ju3AvUYviLZB4KikFD+0jTIyh4 elj6nui5j6HeINBSDmNWHrIdG34Uv3wns0bdy9KTaoVYV+kisqyRNmJSOgrYLuePTrad lA3IdMFJZtWBxBXHGSaG/pYJoPXIiHRGQ618S7d0TpMG/bMbJyArJDrv/7cZrSJ2Yojz mFwtdlJXC2TzgWARoJGIRfZ659fxiIKfJZwTq6NzfUmje2J3LyDHznp3jhgy78USqdaf r3yjjGj0lEMDSnlPQp5OvFZlLTcgShRmFUDnTX8/kuG4fVTST5BA+0DKvJ/FMGBpjY70 VFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jV8bljM3lK+GBB6jw/WspxqJuyJuh/lf4f+szOAk3Fw=; b=Sniz3htTOy2XWU16P8wa/Ogb2qLiEEjqcXIcpiWlbvKB2+5uml1YoNWQc3VZuWkGbB 9F9I8/yxk+sjdo32I4WoZQkrr3OdTRxsj8mwAK6bTWLw3aYtyhd2dnL008FJ37RjtQoH fs3bCD6bWxKr7jVmNhsVG5uwfVcsL1locRnbyqIXyVVwOazSYkxmNlQYB34PcW0WZbmg oKlzW007xqWO1yY+M4Y8NnmQOKbiUO2pkUE//sdtAj9Y7mXkiBonQOLNazo24ZPrTgJY hoWROZ/AITdMRh73lSjpyljau+h13e88wqB4JpemO81BFAkHym/FJuDSa7rVsZHU2BJK xu+A== X-Gm-Message-State: AOAM533MccxdBmMPzNghAQH64DAIEUMPTaoLwnhiF766fV6F8XGc6R2p KUMgBEe0mtlUldlvy1ZGQxbZS/UhNozcFfvJZTQ/YQ== X-Google-Smtp-Source: ABdhPJzkzDW/A2xwJZao0bULy5cxXeAqA2rpndP/DYOEayvx3lxC0orZ2wXvB+yxIaKuMONJzHiBClgTfH9lIzLya+E= X-Received: by 2002:a37:9d4:: with SMTP id 203mr2555955qkj.277.1598975430108; Tue, 01 Sep 2020 08:50:30 -0700 (PDT) MIME-Version: 1.0 References: <20200901065758.1141786-1-brianvv@google.com> <52832405-fa37-38fb-b8fb-d7bd7a0d1d52@gmail.com> In-Reply-To: <52832405-fa37-38fb-b8fb-d7bd7a0d1d52@gmail.com> From: Brian Vazquez Date: Tue, 1 Sep 2020 08:50:18 -0700 Message-ID: Subject: Re: [PATCH] net: ipv6: fix __rt6_purge_dflt_routers when forwarding is not set on all ifaces To: David Ahern Cc: Eric Dumazet , Brian Vazquez , "David S . Miller" , LKML , netdev , David Ahern Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hey David, On Tue, Sep 1, 2020 at 7:57 AM David Ahern wrote: > > On 9/1/20 1:56 AM, Eric Dumazet wrote: > > On Tue, Sep 1, 2020 at 8:58 AM Brian Vazquez wrote: > >> > >> The problem is exposed when the system has multiple ifaces and > >> forwarding is enabled on a subset of them, __rt6_purge_dflt_routers will > >> clean the default route on all the ifaces which is not desired. > >> > >> This patches fixes that by cleaning only the routes where the iface has > >> forwarding enabled. > >> > >> Fixes: z ("net: ipv6: Fix processing of RAs in presence of VRF") > > are you sure that is a Fixes tag for this problem? looking at that > change it only handles RA for tables beyond the main table; it does not > change the logic of how many or which routes are purged. That commit also added RT6_TABLE_HAS_DFLT_ROUTER so I thought that was the commit needed to be mentioned. But probably it shouldn't? Also Am I missing something or this is only called on on the sysctl path? > > >