From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A76C433E2 for ; Mon, 31 Aug 2020 16:52:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D14D20707 for ; Mon, 31 Aug 2020 16:52:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PKX3NGBd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728822AbgHaQwS (ORCPT ); Mon, 31 Aug 2020 12:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728797AbgHaQwI (ORCPT ); Mon, 31 Aug 2020 12:52:08 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F623C061575 for ; Mon, 31 Aug 2020 09:52:08 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id j188so3598153vsd.2 for ; Mon, 31 Aug 2020 09:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v2wssN0DfVl0Q5ulsK8rehD0qys9A1UTSyxawRAlJec=; b=PKX3NGBdootImldgizkUZ9JNq2aRTpLy+LDPXgaGjN67aJZcX5pKbxjF6UCyW/HP/1 1xIphJEPk/1dlpzCnvwdr8psoRTZ4SQXSMEmtmvUrQlJjlhEMVNcqa79KrQe88WEXmBS Tu8vgti347fq8k6r++gj5T7TkTnDDswBF6FeM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v2wssN0DfVl0Q5ulsK8rehD0qys9A1UTSyxawRAlJec=; b=D7zcPXcZLgCOa9XDWhlN/4PLpJjQorCEzFIFnvjvroa4yD4hLxDUaWBUB+ObsTNsQh HaUsy3q4LSZAolJkq6wrudFBHqoPFtpEqk90aF6MDEpOws6P1RNZg66U/kup1hr3ocu1 cexPRkTcajm8pSMGdYv+/lShd1BNKJRQ28iCsd2lz86i679XqQhSdYgEzDNNIP5A98PN RJsUQbF80yl/CvckjQBONpHoXixnxSaEXdRlpLo3Gk00uCzznJn9C8HuXlcLMiayiiTy xsUf3iaCFgi8c8gT0p5TYteTeEnGTcB3V5Eg+cxEenefkwtsMHu/cvPs+V/ok1FDC2GZ xRWA== X-Gm-Message-State: AOAM531wTuc5dASDqIwMU8v8IT52ExvuYou04Tj54yxYopd9nyjRnT3n DxCShk196CX8ZcZg1dzss0qWE8YzpLAOojkDRazjFw== X-Google-Smtp-Source: ABdhPJzRl4IzM+/5e+TD8Pd7j+A6SmKTwYoGY5YNvdrKb+tJbT1J0kMH3uJc5Yi9i1lQvDnOm0uTXj7cCiaXUmoq3bo= X-Received: by 2002:a05:6102:1045:: with SMTP id h5mr2083568vsq.42.1598892727414; Mon, 31 Aug 2020 09:52:07 -0700 (PDT) MIME-Version: 1.0 References: <20200826154719.1.I24fb6cc377d03d64d74f83cec748afd12ee33e37@changeid> In-Reply-To: From: Abhishek Pandit-Subedi Date: Mon, 31 Aug 2020 09:51:56 -0700 Message-ID: Subject: Re: [PATCH] Bluetooth: Clear suspend tasks on unregister To: Marcel Holtmann Cc: linux-bluetooth , CrosBT Upstreaming , "David S. Miller" , Johan Hedberg , netdev , kernel list , Jakub Kicinski , Miao-chen Chou Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org v2 sent with fix. On Mon, Aug 31, 2020 at 8:49 AM Marcel Holtmann wrote: > > Hi Abhishek, > > > While unregistering, make sure to clear the suspend tasks before > > cancelling the work. If the unregister is called during resume from > > suspend, this will unnecessarily add 2s to the resume time otherwise. > > > > Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race) > > Signed-off-by: Abhishek Pandit-Subedi > > --- > > This was discovered with RT8822CE using the btusb driver. This chipset > > will reset on resume during system suspend and was unnecessarily adding > > 2s to every resume. Since we're unregistering anyway, there's no harm in > > just clearing the pending events. > > > > net/bluetooth/hci_core.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > > index 68bfe57b66250f..ed4cb3479433c0 100644 > > --- a/net/bluetooth/hci_core.c > > +++ b/net/bluetooth/hci_core.c > > @@ -3442,6 +3442,16 @@ void hci_copy_identity_address(struct hci_dev *hdev, bdaddr_t *bdaddr, > > } > > } > > > > +static void hci_suspend_clear_tasks(struct hci_dev *hdev) > > +{ > > + int i; > > + > > + for (i = 0; i < __SUSPEND_NUM_TASKS; ++i) > > + clear_bit(i, hdev->suspend_tasks); > > I prefer i++ instead of ++i. > > Regards > > Marcel >