Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: "Kevin(Yudong) Yang" <yyd@google.com>,
	netdev <netdev@vger.kernel.org>,
	Neal Cardwell <ncardwell@google.com>
Subject: Re: [PATCH ethtool,v2] ethtool: add support show/set-time-stamping
Date: Tue, 8 Sep 2020 13:17:41 +0200	[thread overview]
Message-ID: <CANn89iJ=5jXz8RxXx1qtVaaoibU+Rr-qvkH8f89N6gtxBoh84A@mail.gmail.com> (raw)
In-Reply-To: <20200908103723.e4klmj5u6hvh6s4d@lion.mk-sys.cz>

On Tue, Sep 8, 2020 at 12:37 PM Michal Kubecek <mkubecek@suse.cz> wrote:

>
> All this sounds as if the actual reason why you want this in ethtool -
> and implemented using existing ioctl - were to provide a workaround for
> your internal company processes which make it way harder to add a small
> utility than to embed essentially the same code into another which has
> been approved already. I understand that company processes sometimes
> work like that (we have a customer who once asked us to patch kernel for
> something that could be easily achieved by setting one sysctl on boot
> becuse it was easier for them to deploy an updated kernel than to edit
> a config file in their image) but I don't think this is a convincing
> argument for upstream code inclusion.
>

OK, we will carry this internally then.

We are not going to fight against some trivial change.

      reply	other threads:[~2020-09-08 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 14:07 Kevin(Yudong) Yang
2020-09-07 12:53 ` Michal Kubecek
2020-09-07 16:56   ` Eric Dumazet
2020-09-07 21:25     ` Michal Kubecek
2020-09-08  5:35       ` Eric Dumazet
2020-09-08 10:37         ` Michal Kubecek
2020-09-08 11:17           ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANn89iJ=5jXz8RxXx1qtVaaoibU+Rr-qvkH8f89N6gtxBoh84A@mail.gmail.com' \
    --to=edumazet@google.com \
    --cc=mkubecek@suse.cz \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=yyd@google.com \
    --subject='Re: [PATCH ethtool,v2] ethtool: add support show/set-time-stamping' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).