From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471E1C4320A for ; Wed, 28 Jul 2021 07:44:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D49A60FD8 for ; Wed, 28 Jul 2021 07:44:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234351AbhG1HoR (ORCPT ); Wed, 28 Jul 2021 03:44:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233469AbhG1HoQ (ORCPT ); Wed, 28 Jul 2021 03:44:16 -0400 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98049C061757 for ; Wed, 28 Jul 2021 00:44:15 -0700 (PDT) Received: by mail-il1-x133.google.com with SMTP id y4so1858407ilp.0 for ; Wed, 28 Jul 2021 00:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=engleder-embedded-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LvNKTuZIP029zDvkIOsZD+5XM30Oo0b53Nsp0ruBkBo=; b=qMqOinJ/YSFyv9KY7Ult3nqZBH16CJyCmhUIPkxsHadG3+sxBQCXu1RZrVt98Yln0N 0N6bzvYU8LbeSm8otNR406LOdbDSIhjkJks2tBvGVtRc1oogy700N/grQjlDB1b101qD xdI4UTp60JRgAaVuWMIhnRAQxaG1/UloNnR/qxtdpGUkns5+qEf/qJJ3okf/avj2no4O ILgM91Kr4bol9acA254SjIjjAYK7tYJ2hKWUaSmzksgr0Mto1wWf8IHnJcZ/QHw8keVP J1TyU6uaCijvKcapuVeVFYOmi1oK8M9ZYJf+SuSkueAABZLXcqr2GkwcapTkUa54gswx e6Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LvNKTuZIP029zDvkIOsZD+5XM30Oo0b53Nsp0ruBkBo=; b=Ir40JDLmjC7oCt76k+xSAJR0JHH/wecV6xo+A7/K/rnpRf3vJ0YmNReWv9vUv6Pgh5 YF61uporcfVIRK6g7CqOd/DmDoN2FABOu5zfWmeWnJ01xL+WPIAUnJXUfSnCqwwICE5A 2CRgJLA57v6kTOhv5xa2bgLhL5lsCkGn+wcPlLHWOYsP100NNLKWe4HIuYOs/fZtzm1+ Jchvw4PkEBdkPgK/SnlC7TncyoZ04G/59GsUXYB5sVfKZDCucWFT9vE/vP/yvZU6CBzb u1uk+Ga1Lmmhfz1Tus5VaWKsRkvevfrjfVxi1ZppN6cTv/4ddFmUJkBB2Q3v6TxMq8HJ e37Q== X-Gm-Message-State: AOAM531rFC69P38gNZndAlu0zO+3VxWJJOHfMQzvCRuwO0dJH7VZu54H nXAcK2aimqiUyqhFAvGmMXSVldwT9+3RJHFIP9hjMA== X-Google-Smtp-Source: ABdhPJx9rioXjnavKmQEukEOy7O9wfxOzAEHagK/fM4qpTNDzN7r08+v5ARhnCaLATDu8WIpJr6TpaAstT3B4BsgoD8= X-Received: by 2002:a05:6e02:dec:: with SMTP id m12mr1030131ilj.38.1627458255072; Wed, 28 Jul 2021 00:44:15 -0700 (PDT) MIME-Version: 1.0 References: <20210726194603.14671-1-gerhard@engleder-embedded.com> <20210726194603.14671-3-gerhard@engleder-embedded.com> In-Reply-To: From: Gerhard Engleder Date: Wed, 28 Jul 2021 09:44:04 +0200 Message-ID: Subject: Re: [PATCH net-next 2/5] dt-bindings: net: Add tsnep Ethernet controller To: Michal Simek Cc: Rob Herring , David Miller , Jakub Kicinski , netdev , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 28, 2021 at 7:13 AM Michal Simek wrote: > On 7/27/21 10:25 PM, Rob Herring wrote: > > On Tue, Jul 27, 2021 at 12:35 PM Gerhard Engleder > > wrote: > >> > >> On Tue, Jul 27, 2021 at 1:35 AM Rob Herring wrote: > >>>> +properties: > >>>> + compatible: > >>>> + oneOf: > >>> > >>> Don't need oneOf when there is only one entry. > >> > >> I will fix that. > >> > >>>> + - enum: > >>>> + - engleder,tsnep > >>> > >>> tsnep is pretty generic. Only 1 version ever? Or differences are/will > >>> be discoverable by other means. > >> > >> Differences shall be detected by flags in the registers; e.g., a flag for > >> gate control support. Anyway a version may make sense. Can you > >> point to a good reference binding with versions? I did not find a > >> network controller binding with versions. > > > > Some of the SiFive IP blocks have versions. Version numbers are the > > exception though. Ideally they would correspond to some version of > > your FPGA image. I just don't want to see 'v1' because that sounds > > made up. The above string can mean 'v1' or whatever version you want. > > I'm fine if you just add some description here about feature flag > > registers. > > Don't Xilinx design tool (vivado) force you to use IP version? > Normally all Xilinx IPs have certain version because that's the only way > how to manage it. Yes I use an IP version in the Xilinx design tool. I use it as a version of the VHDL code itself. In my case this version is not related to the hardware software interface. The goal is to keep the hardware software interface compatible, so the IP version should not be relevant. Gerhard