Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"
@ 2021-08-26 12:01 Colin King
2021-08-26 14:50 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-08-26 12:01 UTC (permalink / raw)
To: Raju Rangoju, David S . Miller, Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There are spelling mistakes in dev_err and dev_info messages. Fix them.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
index 163efab27e9b..5060d3998889 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
@@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
write_unlock_bh(&ctbl->lock);
dev_err(adap->pdev_dev,
"CLIP FW cmd failed with error %d, "
- "Connections using %pI6c wont be "
+ "Connections using %pI6c won't be "
"offloaded",
ret, ce->addr6.sin6_addr.s6_addr);
return ret;
@@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
} else {
write_unlock_bh(&ctbl->lock);
dev_info(adap->pdev_dev, "CLIP table overflow, "
- "Connections using %pI6c wont be offloaded",
+ "Connections using %pI6c won't be offloaded",
(void *)lip);
return -ENOMEM;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"
2021-08-26 12:01 [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't" Colin King
@ 2021-08-26 14:50 ` Joe Perches
2021-08-26 15:19 ` Denis Kirjanov
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2021-08-26 14:50 UTC (permalink / raw)
To: Colin King, Raju Rangoju, David S . Miller, Jakub Kicinski, netdev
Cc: kernel-janitors, linux-kernel
On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are spelling mistakes in dev_err and dev_info messages. Fix them.
[]
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
[]
> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
> write_unlock_bh(&ctbl->lock);
> 1 file changed, 2 insertions(+), 2 deletions(-)
> dev_err(adap->pdev_dev,
> "CLIP FW cmd failed with error %d, "
> - "Connections using %pI6c wont be "
> + "Connections using %pI6c won't be "
> "offloaded",
> ret, ce->addr6.sin6_addr.s6_addr);
> return ret;
> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
> } else {
> write_unlock_bh(&ctbl->lock);
> dev_info(adap->pdev_dev, "CLIP table overflow, "
> - "Connections using %pI6c wont be offloaded",
> + "Connections using %pI6c won't be offloaded",
> (void *)lip);
This is an unnecessary cast.
And these could coalesce the format fragments and add newlines too.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"
2021-08-26 14:50 ` Joe Perches
@ 2021-08-26 15:19 ` Denis Kirjanov
0 siblings, 0 replies; 3+ messages in thread
From: Denis Kirjanov @ 2021-08-26 15:19 UTC (permalink / raw)
To: Joe Perches
Cc: Colin King, Raju Rangoju, David S . Miller, Jakub Kicinski,
netdev, kernel-janitors, linux-kernel
On 8/26/21, Joe Perches <joe@perches.com> wrote:
> On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are spelling mistakes in dev_err and dev_info messages. Fix them.
> []
>> diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
>> b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
> []
>> @@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> write_unlock_bh(&ctbl->lock);
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> dev_err(adap->pdev_dev,
>> "CLIP FW cmd failed with error %d, "
>> - "Connections using %pI6c wont be "
>> + "Connections using %pI6c won't be "
>> "offloaded",
>> ret, ce->addr6.sin6_addr.s6_addr);
>> return ret;
>> @@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
>> u32 *lip, u8 v6)
>> } else {
>> write_unlock_bh(&ctbl->lock);
>> dev_info(adap->pdev_dev, "CLIP table overflow, "
>> - "Connections using %pI6c wont be offloaded",
>> + "Connections using %pI6c won't be offloaded",
>> (void *)lip);
>
> This is an unnecessary cast.
> And these could coalesce the format fragments and add newlines too.
and fix the leftover in the comment:
./t4_hw.c:7185: * set wont be sent when we are flashing FW.
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-26 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 12:01 [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't" Colin King
2021-08-26 14:50 ` Joe Perches
2021-08-26 15:19 ` Denis Kirjanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).