Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pravin Shelar <pravin.ovn@gmail.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	ovs dev <dev@openvswitch.org>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 3/3] net: openvswitch: remove unnused keep_flows
Date: Wed, 26 Aug 2020 12:23:26 -0700	[thread overview]
Message-ID: <CAOrHB_C=Gx_Z=jpxWQfM20zcJnq2XZ9Kfx-oC-8_zDGrBc4Onw@mail.gmail.com> (raw)
In-Reply-To: <20200825050636.14153-4-xiangxia.m.yue@gmail.com>

On Mon, Aug 24, 2020 at 10:08 PM <xiangxia.m.yue@gmail.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> keep_flows was introduced by [1], which used as flag to delete flows or not.
> When rehashing or expanding the table instance, we will not flush the flows.
> Now don't use it anymore, remove it.
>
> [1] - https://github.com/openvswitch/ovs/commit/acd051f1761569205827dc9b037e15568a8d59f8
> Cc: Pravin B Shelar <pshelar@ovn.org>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>

This patch looks good. But its fixing memory leak, I guess the patch
that removed dependedcy on keep_flows is in net-next. so we are good.

Acked-by: Pravin B Shelar <pshelar@ovn.org>

  reply	other threads:[~2020-08-26 19:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  5:06 [PATCH net-next v3 0/3] net: openvswitch: improve codes xiangxia.m.yue
2020-08-25  5:06 ` [PATCH net-next v3 1/3] net: openvswitch: improve coding style xiangxia.m.yue
2020-08-25 21:51   ` Stefano Brivio
2020-09-01 11:54     ` Tonghao Zhang
2020-08-25  5:06 ` [PATCH net-next v3 2/3] net: openvswitch: refactor flow free function xiangxia.m.yue
2020-08-26 19:23   ` Pravin Shelar
2020-08-25  5:06 ` [PATCH net-next v3 3/3] net: openvswitch: remove unnused keep_flows xiangxia.m.yue
2020-08-26 19:23   ` Pravin Shelar [this message]
2020-08-25 16:37 ` [PATCH net-next v3 0/3] net: openvswitch: improve codes David Miller
2020-08-26  7:09   ` Pravin Shelar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOrHB_C=Gx_Z=jpxWQfM20zcJnq2XZ9Kfx-oC-8_zDGrBc4Onw@mail.gmail.com' \
    --to=pravin.ovn@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=netdev@vger.kernel.org \
    --cc=xiangxia.m.yue@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    --subject='Re: [PATCH net-next v3 3/3] net: openvswitch: remove unnused keep_flows' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).