Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH V1 net-next 1/5] dt-bindings: fec: add the missing clocks properties
Date: Thu, 15 Jul 2021 05:29:42 +0000	[thread overview]
Message-ID: <DB8PR04MB6795E1FEE11395000374B048E6129@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210714231914.GB3723991@robh.at.kernel.org>


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2021年7月15日 7:19
> To: Joakim Zhang <qiangqing.zhang@nxp.com>
> Cc: davem@davemloft.net; kuba@kernel.org; andrew@lunn.ch;
> netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH V1 net-next 1/5] dt-bindings: fec: add the missing clocks
> properties
> 
> On Fri, Jul 09, 2021 at 04:18:19PM +0800, Joakim Zhang wrote:
> > From: Fugang Duan <fugang.duan@nxp.com>
> >
> > Both driver and dts have already used these clocks properties, so add
> > the missing clocks info.
> >
> > Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/net/fsl-fec.txt | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> 
> There's enough changes in this series, please convert this to schema.

Hi Rob,

Ok, I will first convert this binding into schema, then resend this patch set.

Best Regards,
Joakim Zhang
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt
> > b/Documentation/devicetree/bindings/net/fsl-fec.txt
> > index 9b543789cd52..6754be1b91c4 100644
> > --- a/Documentation/devicetree/bindings/net/fsl-fec.txt
> > +++ b/Documentation/devicetree/bindings/net/fsl-fec.txt
> > @@ -39,6 +39,17 @@ Optional properties:
> >    tx/rx queues 1 and 2. "int0" will be used for queue 0 and ENET_MII
> interrupts.
> >    For imx6sx, "int0" handles all 3 queues and ENET_MII. "pps" is for the
> pulse
> >    per second interrupt associated with 1588 precision time protocol(PTP).
> > +- clocks: Phandles to input clocks.
> > +- clock-name: Should be the names of the clocks
> > +  - "ipg", for MAC ipg_clk_s, ipg_clk_mac_s that are for register accessing.
> > +  - "ahb", for MAC ipg_clk, ipg_clk_mac that are bus clock.
> > +  - "ptp"(option), for IEEE1588 timer clock that requires the clock.
> > +  - "enet_clk_ref"(option), for MAC transmit/receiver reference clock like
> > +    RGMII TXC clock or RMII reference clock. It depends on board design,
> > +    the clock is required if RGMII TXC and RMII reference clock source from
> > +    SOC internal PLL.
> > +  - "enet_out"(option), output clock for external device, like supply clock
> > +    for PHY. The clock is required if PHY clock source from SOC.
> >
> >  Optional subnodes:
> >  - mdio : specifies the mdio bus in the FEC, used as a container for
> > phy nodes
> > --
> > 2.17.1
> >
> >

  reply	other threads:[~2021-07-15  5:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  8:18 [PATCH V1 net-next 0/5] net: fec: add support for i.MX8MQ and i.MX8QM Joakim Zhang
2021-07-09  8:18 ` [PATCH V1 net-next 1/5] dt-bindings: fec: add the missing clocks properties Joakim Zhang
2021-07-14 23:19   ` Rob Herring
2021-07-15  5:29     ` Joakim Zhang [this message]
2021-07-09  8:18 ` [PATCH V1 net-next 2/5] dt-bindings: fec: add RGMII delayed clock property Joakim Zhang
2021-07-14 23:19   ` Rob Herring
2021-07-14 23:34     ` Andrew Lunn
2021-07-09  8:18 ` [PATCH V1 net-next 3/5] net: fec: add imx8mq and imx8qm new versions support Joakim Zhang
2021-07-14 23:18   ` Rob Herring
2021-07-09  8:18 ` [PATCH V1 net-next 4/5] net: fec: add eee mode tx lpi support Joakim Zhang
2021-07-09  8:18 ` [PATCH V1 net-next 5/5] net: fec: add MAC internal delayed clock feature support Joakim Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR04MB6795E1FEE11395000374B048E6129@DB8PR04MB6795.eurprd04.prod.outlook.com \
    --to=qiangqing.zhang@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    --subject='RE: [PATCH V1 net-next 1/5] dt-bindings: fec: add the missing clocks properties' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).