Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joakim Zhang <qiangqing.zhang@nxp.com>
To: Fabio Estevam <festevam@gmail.com>, Vladimir Oltean <olteanv@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Shawn Guo <shawnguo@kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>, netdev <netdev@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells
Date: Sat, 24 Jul 2021 05:21:29 +0000	[thread overview]
Message-ID: <DB8PR04MB6795F1B7B273777BA55B81ABE6E69@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5BRt6M=4WrZMWQjYeDcOXMSFhcfjZ95tdUkst5Jm=yB6A@mail.gmail.com>


Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: 2021年7月23日 21:16
> To: Vladimir Oltean <olteanv@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>; Shawn Guo
> <shawnguo@kernel.org>; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; Joakim Zhang
> <qiangqing.zhang@nxp.com>; Rob Herring <robh+dt@kernel.org>; netdev
> <netdev@vger.kernel.org>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@vger.kernel.org>
> Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio
> #address-cells/#size-cells
> 
> Hi Vladimr,
> 
> On Fri, Jul 23, 2021 at 10:08 AM Vladimir Oltean <olteanv@gmail.com> wrote:
> 
> > Are you actually sure this is the correct fix? If I look at mdio.yaml,
> > I think it is pretty clear that the "ethernet-phy" subnode of the MDIO
> > controller must have an "@[0-9a-f]+$" pattern, and a "reg" property.
> > If it did, then it wouldn't warn about #address-cells.
> 
> Thanks for reviewing it.
> 
> After double-checking I realize that the correct fix would be to pass the phy
> address, like:
> 
> phy: ethernet-phy@1 {
> reg = <1>;
> 
> Since the Ethernet PHY address is design dependant, I can not make the fix
> myself.
> 
> I will try to ping the board maintainers for passing the correct phy address.

Thanks.

I prepare this patch to fix dtbs_check when convert fec binding into schema.
I realized that we need a "reg" under phy device node, but I also don't know how to add it since
the phy is obviously not on board. And I check the phy code, it supports auto scan for PHYs with empty
"reg" property.

Best Regards,
Joakim Zhang
> Thanks

  parent reply	other threads:[~2021-07-24  5:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 11:28 Fabio Estevam
2021-07-23 13:08 ` Vladimir Oltean
2021-07-23 13:15   ` Fabio Estevam
2021-07-23 13:35     ` Vladimir Oltean
2021-07-24  5:21     ` Joakim Zhang [this message]
2021-07-24 12:48       ` Fabio Estevam
2021-07-24 16:37   ` Florian Fainelli
2021-07-24 17:03     ` Vladimir Oltean
2021-07-24 19:14       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR04MB6795F1B7B273777BA55B81ABE6E69@DB8PR04MB6795.eurprd04.prod.outlook.com \
    --to=qiangqing.zhang@nxp.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --subject='RE: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio #address-cells/#size-cells' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).