Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: Li RongQing <lirongqing@baidu.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Subject: RE: [PATCH][v3] i40e: optimise prefetch page refcount
Date: Fri, 4 Sep 2020 23:45:09 +0000 [thread overview]
Message-ID: <DM6PR11MB289076BE0502BC161EDF82F9BC2D0@DM6PR11MB2890.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1597734477-27859-1-git-send-email-lirongqing@baidu.com>
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
> On Behalf Of Li RongQing
> Sent: Tuesday, August 18, 2020 12:08 AM
> To: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Subject: [PATCH][v3] i40e: optimise prefetch page refcount
>
> refcount of rx_buffer page will be added here originally, so prefetchw
> is needed, but after commit 1793668c3b8c ("i40e/i40evf: Update code to
> better handle incrementing page count"), and refcount is not added
> everytime, so change prefetchw as prefetch,
>
> now it mainly services page_address(), but which accesses struct page
> only when WANT_PAGE_VIRTUAL or HASHED_PAGE_VIRTUAL is defined
> otherwise
> it returns address based on offset, so we prefetch it conditionally
>
> Jakub suggested to define prefetch_page_address in a common header
>
> Reported-by: kernel test robot <lkp@intel.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> diff with v2: fix a build warning -Wvisibility
> diff with v1: create a common function prefetch_page_address
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
> include/linux/prefetch.h | 8 ++++++++
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
Ignore my prior mail on the v2 for this patch. I really was using v3.
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
prev parent reply other threads:[~2020-09-04 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 7:07 Li RongQing
2020-08-18 18:19 ` Jesse Brandeburg
2020-09-04 23:45 ` Brown, Aaron F [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB289076BE0502BC161EDF82F9BC2D0@DM6PR11MB2890.namprd11.prod.outlook.com \
--to=aaron.f.brown@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--subject='RE: [PATCH][v3] i40e: optimise prefetch page refcount' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).