Netdev Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Brown, Aaron F" <aaron.f.brown@intel.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"Topel, Bjorn" <bjorn.topel@intel.com>,
	"Karlsson, Magnus" <magnus.karlsson@intel.com>,
	"kuba@kernel.org" <kuba@kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: use 16B HW descriptors instead of 32B
Date: Sat, 5 Sep 2020 03:01:08 +0000	[thread overview]
Message-ID: <DM6PR11MB2890B2527FB513C92041C152BC2A0@DM6PR11MB2890.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200825113556.18342-3-bjorn.topel@gmail.com>

> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Björn Töpel
> Sent: Tuesday, August 25, 2020 4:36 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; bpf@vger.kernel.org; Topel, Bjorn
> <bjorn.topel@intel.com>; Karlsson, Magnus <magnus.karlsson@intel.com>;
> kuba@kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: use 16B HW
> descriptors instead of 32B
> 
> From: Björn Töpel <bjorn.topel@intel.com>
> 
> The i40e NIC supports two flavors of HW descriptors, 16 and 32
> byte. The latter has, obviously, room for more offloading
> information. However, the only fields of the 32B HW descriptor that is
> being used by the driver, is also available in the 16B descriptor.
> 
> In other words; Reading and writing 32 bytes instead of 16 byte is a
> waste of bus bandwidth.
> 
> This commit starts using 16 byte descriptors instead of 32 byte
> descriptors.
> 
> For AF_XDP the rx_drop benchmark was improved by 2%.
> 
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h         |  2 +-
>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 10 ++++------
>  drivers/net/ethernet/intel/i40e/i40e_main.c    |  4 ++--
>  drivers/net/ethernet/intel/i40e/i40e_trace.h   |  6 +++---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c    |  6 +++---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.h    |  2 +-
>  drivers/net/ethernet/intel/i40e/i40e_type.h    |  5 ++++-
>  7 files changed, 18 insertions(+), 17 deletions(-)
> 
Tested-by: Aaron Brown <aaron.f.brown@intel.com>

  reply	other threads:[~2020-09-05  3:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 11:35 [PATCH net-next v2 0/3] i40e driver performance tweaks for AF_XDP Björn Töpel
2020-08-25 11:35 ` [PATCH net-next v2 1/3] i40e, xsk: remove HW descriptor prefetch in AF_XDP path Björn Töpel
2020-09-05  2:58   ` [Intel-wired-lan] " Brown, Aaron F
2020-08-25 11:35 ` [PATCH net-next v2 2/3] i40e: use 16B HW descriptors instead of 32B Björn Töpel
2020-09-05  3:01   ` Brown, Aaron F [this message]
2020-08-25 11:35 ` [PATCH net-next v2 3/3] i40e, xsk: move buffer allocation out of the Rx processing loop Björn Töpel
2020-09-05  3:03   ` [Intel-wired-lan] " Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB2890B2527FB513C92041C152BC2A0@DM6PR11MB2890.namprd11.prod.outlook.com \
    --to=aaron.f.brown@intel.com \
    --cc=bjorn.topel@gmail.com \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --subject='RE: [Intel-wired-lan] [PATCH net-next v2 2/3] i40e: use 16B HW descriptors instead of 32B' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).