Netdev Archive on
help / color / mirror / Atom feed
* [net-next PATCH] net: act_skbedit: Fix tc action skbedit queue_mapping
@ 2021-08-09 23:41 Amritha Nambiar
  2021-08-10  0:51 ` Alexander Duyck
  0 siblings, 1 reply; 6+ messages in thread
From: Amritha Nambiar @ 2021-08-09 23:41 UTC (permalink / raw)
  To: netdev, kuba
  Cc: alexander.duyck, jhs, jiri, xiyou.wangcong, sridhar.samudrala,

For skbedit action queue_mapping to select the transmit queue,
queue_mapping takes the value N for tx-N (where N is the actual
queue number). However, current behavior is the following:
1. Queue selection is off by 1, tx queue N-1 is selected for
   action skbedit queue_mapping N. (If the general syntax for queue
   index is 1 based, i.e., action skbedit queue_mapping N would
   transmit to tx queue N-1, where N >=1, then the last queue cannot
   be used for transmit as this fails the upper bound check.)
2. Transmit to first queue of TCs other than TC0 selects the
   next queue.
3. It is not possible to transmit to the first queue (tx-0) as
   this fails the bounds check, in this case the fallback
   mechanism for hash calculation is used.

Fix the call to skb_set_queue_mapping(), the code retrieving the
transmit queue uses skb_get_rx_queue() which subtracts the queue
index by 1. This makes it so that "action skbedit queue_mapping N"
will transmit to tx-N (including the first and last queue).

Signed-off-by: Amritha Nambiar <>
Reviewed-by: Sridhar Samudrala <>
 net/sched/act_skbedit.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c
index e5f3fb8b00e3..a7bba15c74c4 100644
--- a/net/sched/act_skbedit.c
+++ b/net/sched/act_skbedit.c
@@ -59,7 +59,7 @@ static int tcf_skbedit_act(struct sk_buff *skb, const struct tc_action *a,
 	if (params->flags & SKBEDIT_F_QUEUE_MAPPING &&
 	    skb->dev->real_num_tx_queues > params->queue_mapping)
-		skb_set_queue_mapping(skb, params->queue_mapping);
+		skb_set_queue_mapping(skb, params->queue_mapping + 1);
 	if (params->flags & SKBEDIT_F_MARK) {
 		skb->mark &= ~params->mask;
 		skb->mark |= params->mark & params->mask;

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-18  0:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 23:41 [net-next PATCH] net: act_skbedit: Fix tc action skbedit queue_mapping Amritha Nambiar
2021-08-10  0:51 ` Alexander Duyck
2021-08-10  1:20   ` Nambiar, Amritha
2021-08-10 14:03     ` Alexander Duyck
2021-08-18  0:16       ` Nambiar, Amritha
2021-08-18  0:52         ` Alexander Duyck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).